Fix the errors/warnings reported by PHP_CodeSniffer

The phpcs issues mentioned in Problem/Motivation have been resolved.

Hi,
Please review this patch.

Good Morning! Thanks for the work, the patch fixes a lot of standard issues. Some standard issues still persist, in the attached file I mention them.

I'll work on it.

Here's the new patch with the requested changes.

I'll review it.

After checking the module files again with PHPCS there are still some errors.
I'll try to fix them.

FILE: /home/ramonsv/Documents/Projects/Drupal/web/modules/contrib/conflict/conflict.module
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
 115 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/ramonsv/Documents/Projects/Drupal/web/modules/contrib/conflict/modules/conflict_paragraphs/src/Plugin/Conflict/FieldComparator/FieldComparatorParagraphReference.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 256 | WARNING | Unused variable $removed_entity_form_display.
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/ramonsv/Documents/Projects/Drupal/web/modules/contrib/conflict/modules/conflict_paragraphs/conflict_paragraphs.module
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | Missing short description in doc comment
---------------------------------------------------------------------------------------------------------------------------------


FILE: /home/ramonsv/Documents/Projects/Drupal/web/modules/contrib/conflict/src/Form/ConflictResolutionDialogFormBuilder.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 11 WARNINGS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  54 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  63 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  78 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  92 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 103 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 185 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 185 | ERROR   | The array declaration extends to column 176 (the limit is 80). The array content should be split up over multiple lines
 189 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 197 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 197 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/ramonsv/Documents/Projects/Drupal/web/modules/contrib/conflict/src/Entity/ContentEntityConflictHandler.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
 197 | ERROR   | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
 212 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 225 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 295 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 296 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------------

Time: 616ms; Memory: 14MB

Please, review it.

I will review it.

After reviewing the module, i found more PHPCS terrors.
I'll try to fix them.

FILE: /home/alexanderj/contrib/contrib-9/web/modules/contrib/conflict/js/conflict_resolution.js
-----------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 25 | ERROR | [x] Expected 1 space before "!=="; 2 found
 25 | ERROR | [x] Expected 1 space before "!=="; 2 found
-----------------------------------------------------------------------------------------------

FILE: /home/alexanderj/contrib/contrib-9/web/modules/contrib/conflict/src/Form/ConflictResolutionDialogFormBuilder.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 185 | ERROR | The array declaration extends to column 183 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------

Please, review it.

I'll review it.

Everything in order. There are some minor warnings in JS a file but i dont think they would improve code readability.

+/**
+ * @file
+ */
+

The usual short description for a module is Hook implementations for the [module name] module. Using an empty comment is just a workaround.

-
-  // auto merge
+  // Auto merge

That comment is meaningless. Instead of fixing a word spelling, it would be better to remove the comment.

+/**
+ * Resolves conflicts on content entities.
+ */
 class MergeRemoteStructure extends MergeStrategyBase {
 

That short description could be correct, but it needs to be more specific, as that class does not removed every content entity conflict.

-        $local_paragraph_ids_unsorted = array_map(function ($value) {return $value['target_id'];}, $local_entity->get($property)->getValue());
-        $server_paragraph_ids_unsorted = array_map(function ($value) {return $value['target_id'];}, $remote_entity->get($property)->getValue());
-        $original_paragraph_ids_unsorted = array_map(function ($value) {return $value['target_id'];}, $original_entity->get($property)->getValue());
+        $local_paragraph_ids_unsorted = array_map(function ($value) {
+          return $value['target_id'];
+
+        }, $local_entity->get($property)->getValue());
+        $server_paragraph_ids_unsorted = array_map(function ($value) {
+          return $value['target_id'];
+
+        }, $remote_entity->get($property)->getValue());
+        $original_paragraph_ids_unsorted = array_map(function ($value) {
+          return $value['target_id'];
+
+        }, $original_entity->get($property)->getValue());

The changed code is not more readable.

-          // TODO this supports only paragraphs at first level.
+          // @todo this supports only paragraphs at first level.
           if ($form_state) {
             $this->reorderWidgetState($field_item_list, $form_state);

What follows @todo is a sentence: It starts with a capitalized word and it ends with a period.

-            // TODO not yet supported.
+            // @todo not yet supported.
             if ($form_state) {

The sentence following @todo must describe what needs to be changed. In this case, it just describes the actual code.

+/**
+ * Conflict Discovery Interface.
+ */

The short description is missing an article.
Those words are misspelled, since in English words are spelled capitalized basing on specific rules.

+/**
+ * Discover conflicts on content entities.
+ */
 class DefaultConflictDiscovery extends ConflictDiscoveryBase {

If the first word in a short description is a verb, it must use the third-person singular (eats, drinks, tastes.)

Also, why only a ruleset is used instead of the two existing rulesets PHP_CodeSniffer has for Drupal?

Updated issue summary.

I've applied all patches but found some phpcs issues so I created with all fixes. Please review it.

The 8.x-2.x branch is not the recommended branch, which instead is the 3.0.x branch. Issues should be fixed in that branch.