FILE: /var/www/html/web/modules/custom/menu_item_role_access/menu_item_role_access.module
-----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
24 | WARNING | Unused variable $config.
-----------------------------------------------------------------------------------------
FILE: /var/www/html/web/modules/custom/menu_item_role_access/src/Form/ConfigForm.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
10 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/web/modules/custom/menu_item_role_access/src/MenuItemRoleAccessLinkTreeManipulator.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------
79 | WARNING | MenuLinkContent::load calls should be avoided in classes, use dependency injection instead
91 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff_2-6.txt | 3.22 KB | mukesh88 |
| #6 | 3293102-6.patch | 3.98 KB | mukesh88 |
| #4 | Screenshot 2023-03-03 at 12.53.41 PM.png | 136.35 KB | arunkumark |
| #4 | Screenshot 2023-03-03 at 12.53.31 PM.png | 206.28 KB | arunkumark |
| #2 | unused-veriable-found-3293102-2.patch | 604 bytes | ashutosh ahirwal |
Comments
Comment #2
ashutosh ahirwal commentedProviding patch.
Need review.
Comment #3
ashutosh ahirwal commentedComment #4
arunkumarkI tested the patch working as expected to remove the unused variable
$config.Before applying patch:
After applying patch:
But there are a few other warnings. It would be great we are resolving all the warning errors.
Warnings are,
Comment #5
arunkumarkComment #6
mukesh88 commentedFixes PHPCS issues and created patch
Comment #7
hardikpandya commentedThis would be covered as part of https://www.drupal.org/project/menu_item_role_access/issues/3293109 where more work for fixing all phpcs issues is being done. Closing this!