Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
In #3252214: Move tests for integrations between QuickEdit and CKEditor5 into QuickEdit so that it can more easily be moved into contrib we move CKEditor5IntegrationTest into the namespace/module of Quick Edit itself.
However we did not move the JavaScript bit that makes \Drupal\Tests\quickedit\FunctionalJavascript\CKEditor5IntegrationTest::testDiscard() pass.
This is the bit that we're talking about: https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/modules/cke....
To make the deprecation and removal of the Quick Edit module from Core possible, we need to move that bit into the namespace/module of Quick Edit itself as well in a way that it still passes \Drupal\Tests\quickedit\FunctionalJavascript\CKEditor5IntegrationTest::testDiscard().
Since this blocks #3227033: Remove Quick Edit from core, which is Major, also marking this issue as Major.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | core-3292780-3-9.5.x.patch | 7.1 KB | nod_ |
| #3 | core-3292780-3.patch | 6.95 KB | nod_ |
Comments
Comment #2
nod_Comment #3
nod_didn't try to be too fancy, let see what the testbot says.
Comment #4
spokjeFancy, schmanzy!
- JS code concerning the reverting in Quick Edit is moved to the module itself.
-
\Drupal\Tests\quickedit\FunctionalJavascript\CKEditor5IntegrationTest::testDiscard()still passes.- Testbot likes it, so I like it.
RTBC.
Comment #5
nod_haha, well I'm happy too then.
Comment #7
catchCommitted/pushed to 10.1.x, cherry-picked to 10.0.x and the respective patch to 9.5.x, thanks!
Comment #9
spokjeThanks @nod_ for being the JS-Big-Brain needed here.
Thanks @catch for the quick commit, let's hope this was actually the last real code blocking issue for QE-Exit-Stage-Left...
Comment #10
nod_Wow I think that was my fastest patch to commit yet :)
Comment #11
spokjeWhen it comes to QE, nobody (especially catch) takes any chances on other commits getting in the way.
The deprecation/removal of this "beast" has been hard enough as it is.
Sisyphus nods head
Comment #12
xjmComment #13
wim leersYay! This also made the CKEditor 5 module simpler 🤓