Problem/Motivation

The update functions are very old and have an upgrade path that we need to keep updating for new major versions. It has been 6 years since they were added. If someone is really still running a version so old that they didn't run the updates then they will need to do gradual updates to D9 and so on anyway.

Additionally, the requirements hook tests for media_entity 1.x which is no longer compatible with D9+ anyway, so can't possibly fail on D9 and we can remove that too.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_browser-3292703

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Berdir created an issue. See original summary.

Laureatus made their first commit to this issue’s fork.

Laureatus opened merge request !18

Laureatus’s picture

Laureatus
he/him
Primary language German
commented

I deleted the files entity_browser.install and EntityBrowserUpdateHookTest because both files only included code that is not used anymore. Im thankful for any feedback.

Laureatus’s picture

Laureatus
he/him
Primary language German
commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Thanks. so far as good. I added two comments on the MR.

Laureatus opened merge request !19

Laureatus’s picture

Laureatus
he/him
Primary language German
commented

Hi Berdir
I made a commit with the changes you suggested in the MR. I also created an additional MR by accident. My apologies for the confusion.
Have a nice evening and kind regards from Zürich.

Laureatus’s picture

Laureatus
he/him
Primary language German
commented
Status: Needs work » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

No worries, left one small comment on the MR.

Laureatus’s picture

Laureatus
he/him
Primary language German
commented

I changed the description as you requested.

Laureatus’s picture

Laureatus
he/him
Primary language German
commented
Status: Needs work » Needs review
sahilgidwani’s picture

sahilgidwani commented
Assigned: Unassigned » sahilgidwani
sahilgidwani’s picture

sahilgidwani commented
Assigned: sahilgidwani » Unassigned
Status: Needs review » Reviewed & tested by the community

I have checked and reviewed MR and it works perfect for me

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

One small thing left.

rpayanm made their first commit to this issue’s fork.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

I added the change suggested by @Berdir

dermario’s picture

dermario
Primary language German
Location Zürich
commented
Status: Needs review » Reviewed & tested by the community

Set the issue to RTBC since all of Berdir's comments have been implemented.

Dave Reid credited agentrickard.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Dave Reid credited S_Bhandari.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

  • Dave Reid committed 021f2af2 on 8.x-2.x authored by Laureatus 
    Issue #3292703 by Laureatus, rpayanm, Dave Reid, dermario, S_Bhandari,...
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.