Problem/Motivation

core/jquery.once is deprecated and the module needs to use core/once. This is causing modules with this as a dependency or dev dependency to fail deprecations.

Entity Embed already requires 9.2, so no need to bump minimum Drupal core. core/once was added in 9.2

Steps to reproduce

See https://www.drupal.org/pift-ci-job/2410887

Proposed resolution

Get library fixed so other modules can test on 1.x-dev and pass.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_embed-3292304

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mglaman created an issue. See original summary.

mglaman opened merge request !8

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue summary: View changes

phenaproxima made their first commit to this issue’s fork.

  • phenaproxima committed ea61857 on 8.x-1.x authored by mglaman 
    Issue #3292304 by mglaman: Replace usage of core/jquery.once for core/...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Fixed

Looks good to me, passes tests, what else can you ask for. Merged into 8.x-1.x; thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.