Problem/Motivation

After upgrade to php 8.1, strlen() function is deprecated.

Steps to reproduce

Upgrade php version to php8.1

Proposed resolution

Change strlen() to empty()

Remaining tasks

No

User interface changes

No

API changes

No

Data model changes

No

CommentFileSizeAuthor
#7 restrict_by_ip-3292104-7.patch4.86 KBnicrodgers
#5 restrict_by_ip-3292104-5.patch5.28 KBjonnyhocks
#4 restrict_by_ip-strlen_null_parameter_deprecated-3292104-4.patch5.42 KBkjwhite

Issue fork restrict_by_ip-3292104

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cobenash created an issue. See original summary.

cobenash opened merge request !3

dripa’s picture

dripa commented
Status: Active » Reviewed & tested by the community

Thanks, changes in MR fixed the PHP8.1 issues

kjwhite’s picture

kjwhite commented
StatusFileSize
new restrict_by_ip-strlen_null_parameter_deprecated-3292104-4.patch5.42 KB

Patch file attached for use in composer.json files pending this issue's merge.

jonnyhocks’s picture

jonnyhocks commented
StatusFileSize
new restrict_by_ip-3292104-5.patch5.28 KB

I've re-rolled the changes in the recent patch for this issue to be applied against the fork in the D10 updates issue

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

+1 RTBC, these work well to quiet the errors in php 8.1 and Drupal 10 and do so in an elegant fashion.

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new restrict_by_ip-3292104-7.patch4.86 KB

I've re-rolled the patch in #5 to work with the latest MR here https://www.drupal.org/project/restrict_by_ip/issues/3289374

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Reviewed & tested by the community

We can consider #5 to be RTBC as it applies to the dev branch and treat #7 as a utility.

chegor’s picture

chegor commented

+1 RTBC

rocketeerbkw’s picture

rocketeerbkw commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

  • rocketeerbkw committed 9df64855 on 8.x-4.x 
    Issue #3292104 by cobenash, darvanen, DrIPA: Remove use of deprecated...

rocketeerbkw closed merge request !3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.