Problem/Motivation

I have a Geolocation view with a list view attached. The list view previously displayed proximity and was filtered by it. However, as of the update to 3.10 these proximity-related features are no longer working. They work fine in 3.9. The issues are related to the changes in Multiple exposed Proximity Filters not working - it works again if I undo them. Curiously this seems to fix both the filtering itself and the field, even though the field plugin isn't touched directly.

The issue happens when a view has a grouped proximity filter.

Steps to reproduce

I haven't properly replicated this from scratch but I'm attaching configuration for a view that is affected by the issue for reference.

Proposed resolution

We just need to tweak the geolocation_filter_proximity views filter plugin to address the issue without regressing the earlier issue. I'll probably attach a patch today or tomorrow.

CommentFileSizeAuthor
views.view_.facilities.yml52.57 KBdylan donkersgoed

Issue fork geolocation-3292057

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Dylan Donkersgoed created an issue. See original summary.

Dylan Donkersgoed opened merge request !19

dylan donkersgoed’s picture

dylan donkersgoed commented
Title: Issues with proximity on list view attached to Geolocation CommonMap view » Issues with grouped proximity filter
Issue summary: View changes
Status: Active » Needs review

It was because the filter-specific identifier wasn't applied to the groupForm() method, only the normal valueForm method. Didn't realize at first that the view was using aggregation. I've attached an MR that fixes the issue.

christianadamski’s picture

christianadamski commented

Thanks!

But why the 

$form[$identifier . '_center']['#tree'] = TRUE;

?

alina.basarabeanu’s picture

alina.basarabeanu commented

We came across the same issue on our website. The views results were not filtered by the address and the proximity after updating to version 3.10 for the module.
Applying the fork fixed the issue.
I assumed that the property '#tree' is needed on the form element because it has children.

sralton’s picture

sralton commented

Had the same issue on my site. I applied the patch file of the merge request to the Version 3.12 and worked like a charm.

kurttrowbridge’s picture

kurttrowbridge
he/him
commented
Status: Needs review » Reviewed & tested by the community

This also resolved issues with grouped proximity filters on a site of ours. Since others have said the same above, I'm going to mark this as RTBC. Thank you!

socialnicheguru’s picture

socialnicheguru commented

Is this an issue in 4.0@alpha geolocation version?

christianadamski’s picture

christianadamski commented

Tested and works!

Will also manually merge for v4.

christianadamski’s picture

christianadamski commented
Status: Reviewed & tested by the community » Fixed
socialnicheguru’s picture

socialnicheguru commented

Looking forward to fix added to 4.x.

christianadamski’s picture

christianadamski commented

Already pushed to -dev

socialnicheguru’s picture

socialnicheguru commented

There are two pushes. Are they the same? I am trying to add the commits to my composer file on top of 4.x-alpha4. One does not apply while the other does.

christianadamski’s picture

christianadamski commented

Releasing 4.0.0-alpha5

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.