Problem/Motivation

Found too many error in many file of module after phpcs --standard=Drupal command run.

CommentFileSizeAuthor
#5 3291711-fixing-js-coding-standard-5.patch480 bytesnitin_lama
#2 phpcs-standard-Drupal-3291711-2.patch52.36 KBashutosh ahirwal

Issue fork onlyoffice-3291711

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ashutosh Ahirwal created an issue. See original summary.

ashutosh ahirwal’s picture

ashutosh ahirwal commented
Status: Needs work » Needs review
Issue tags: +Novice
StatusFileSize
new phpcs-standard-Drupal-3291711-2.patch52.36 KB

I have updated issue.

need some manual changes by maintainer in CHANGELOG.md file and readme file.

issue in CHANGELOG.md file and readme file is

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/onlyoffice/

FILE: C:\xampp\htdocs\contribute\web\modules\contrib\onlyoffice\CHANGELOG.md
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
7 | WARNING | Line exceeds 80 characters; contains 242 characters
----------------------------------------------------------------------------

FILE: C:\xampp\htdocs\contribute\web\modules\contrib\onlyoffice\README.md
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AND 20 WARNINGS AFFECTING 21 LINES
-----------------------------------------------------------------------------------------
1 | ERROR | File contains UTF-8 byte order mark, which may corrupt your application
21 | WARNING | Line exceeds 80 characters; contains 88 characters
26 | WARNING | Line exceeds 80 characters; contains 232 characters
45 | WARNING | Line exceeds 80 characters; contains 143 characters
46 | WARNING | Line exceeds 80 characters; contains 146 characters
47 | WARNING | Line exceeds 80 characters; contains 98 characters
50 | WARNING | Line exceeds 80 characters; contains 124 characters
63 | WARNING | Line exceeds 80 characters; contains 82 characters
77 | WARNING | Line exceeds 80 characters; contains 119 characters
84 | WARNING | Line exceeds 80 characters; contains 97 characters
86 | WARNING | Line exceeds 80 characters; contains 99 characters
88 | WARNING | Line exceeds 80 characters; contains 125 characters
96 | WARNING | Line exceeds 80 characters; contains 84 characters
98 | WARNING | Line exceeds 80 characters; contains 91 characters
105 | WARNING | Line exceeds 80 characters; contains 92 characters
108 | WARNING | Line exceeds 80 characters; contains 225 characters
114 | WARNING | Line exceeds 80 characters; contains 161 characters
116 | WARNING | Line exceeds 80 characters; contains 147 characters
122 | WARNING | Line exceeds 80 characters; contains 112 characters
126 | WARNING | Line exceeds 80 characters; contains 208 characters
128 | WARNING | Line exceeds 80 characters; contains 89 characters
-----------------------------------------------------------------------------------------

Time: 612ms; Memory: 10MB

Providing patch for other issue. Need review.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Needs review » Needs work

Unable to apply the patch. Seems all the coding standards are resolved without this patch.

Except there is a Drupal practice on the /js/onlyoffice-preview.js

-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
 27 | ERROR | [x] Expected 1 space after "="; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: ashutosh ahirwal » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new 3291711-fixing-js-coding-standard-5.patch480 bytes

True !! the #2 patch cannot be applied. All the coding standards are fixed. As per #3 attaching a patch for the mentioned Drupal practice.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
damiaosj’s picture

damiaosj commented
Assigned: Unassigned » damiaosj

Hello! I'll review!

damiaosj opened merge request !1

damiaosj’s picture

damiaosj commented
Status: Needs review » Reviewed & tested by the community

I've made the review and all seems to be fine!

Also I've made a new Merge Request for this issue and added the patch before my push.

Hope to help!

damiaosj’s picture

damiaosj commented
Assigned: damiaosj » Unassigned

onlyoffice closed merge request !1

onlyoffice’s picture

onlyoffice commented
Version: » 1.0.x-dev
Assigned: Unassigned » onlyoffice
Status: Reviewed & tested by the community » Fixed
Issue tags: -

Corrected
Thanks for your assistance

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.