Problem/Motivation

As originally noted in Drupal Slack (where I asked in #support about where to report this kind of thing):

When upgrading to 9.4.0, I seem to be seeing an effect of https://www.drupal.org/project/drupal/issues/3129043 (a mysql module newly installed), and there's a linked change record noting this was introduced in 9.4.0, but 3129043 doesn't seem to be listed among the changes in the 9.4.0 release notes. (I also looked for it in alpha1, beta1, rc1, and rc2.)

Also, the link for "deprecated module documentation" leads to 404 https://www.drupal.org/project/drupal/releases/docs/core-modules-and-themes/deprecated-and-obsolete-modules-and-themes (the href to it needs a leading /, it seems).

[Then later:]
I'm also seeing diffs seemingly resulting from 3173180 which has a related change notice that it was apparently introduced in 9.4.0 too. The issue was even tagged "9.4.0 release highlights", but I don't see anything in the 9.4.0 release notes (or the preceding rc/beta/alphas) that would have given me a heads-up about all the config diffs I'm seeing. What am I missing?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

maxstarkenburg created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented

When upgrading to 9.4.0, I seem to be seeing an effect of https://www.drupal.org/project/drupal/issues/3129043 (a mysql module newly installed), and there's a linked change record noting this was introduced in 9.4.0, but 3129043 doesn't seem to be listed among the changes in the 9.4.0 release notes. (I also looked for it in alpha1, beta1, rc1, and rc2.)

I agree this change should have been tagged for the release notes; I was not aware of it until regressions were reported related to the change. We have already added regressions related to the release under the known issues.

Also, the link for "deprecated module documentation" leads to 404 https://www.drupal.org/project/drupal/releases/docs/core-modules-and-the... (the href to it needs a leading /, it seems).

I'll fix this; thanks for reporting it!

I'm also seeing diffs seemingly resulting from 3173180 which has a related change notice that it was apparently introduced in 9.4.0 too. The issue was even tagged "9.4.0 release highlights", but I don't see anything in the 9.4.0 release notes (or the preceding rc/beta/alphas) that would have given me a heads-up about all the config diffs I'm seeing. What am I missing?

Release notes and release highlights have two separate purposes. The release notes are for changes that might cause a disruption -- like core now allowing you to install Guzzle 7, or the database issue you noted.

Release highlights, on the other hand, are about new value added in the release. They are added to the frontpage post announcing the release at the product managers' discretion. You can see the paragraph about this roughly halfway down in the post:

New lazy loading configuration option added to image fields
A new lazy loading configuration option is added to image fields in 9.4.0 and most image fields shipped in core are now configured to lazy load. This helps browsers to delay downloading and displaying them until they become visible, which speeds up general page display.

Thanks for your close attention and for reaching out to report these issues!

xjm’s picture

xjm
she/her
Primary language English
commented

I've reopened #3129043: Move core database drivers to modules of their own for a release note; hopefully the folks who worked on that issue can help us add that information so that folks upgrading are aware of it.

xjm’s picture

xjm
she/her
Primary language English
commented
  1. OK one of the framework managers has offered to help with release note for #3129043: Move core database drivers to modules of their own later today.
  2. I've fixed the broken link. :)
  3. Regarding #3173180: Add UI for 'loading' html attribute to images, was there something disruptive for your upgrade about it? As far as I understood it's just a new feature. It has an upgrade path to add new config, but normally those are supposed to "just work" when the site owner follows the recommended site update process.
xjm’s picture

xjm
she/her
Primary language English
commented

For #1, the release notes have been updated.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Thanks XJM. This is super good.

I gave the release notes another read, and I checked every link again, and I think we're all set.

maxstarkenburg’s picture

maxstarkenburg
he/him
commented

Thanks, @xjm (and @greg-boggs)! To respond to your "was there something disruptive" question, I thought I'd provide some context of why I was confused/concerned. I'm at a new job where one of my tasks is to perform core/contrib updates to several websites, which are all new to me (as of ~2 months ago), and some of which are even pretty new to the agency (inherited from other developers/companies). Several of the sites have decent amounts of technical debt, and others simply have more custom code than I'd expect, or config choices that are new to me. While we've been beefing up automated testing, in the meanwhile I've been trying to scan release notes (specifically any "Changes since ..." sections) of any packages with updates, for things I might wanna grep for, or hammer at, to check for potential regressions after upgrading. While I too imagine that the the new core DB driver modules and lazy-loading config will probably "just work", after having scanned release notes for post-9.3 changes on Friday (and updating core with composer, and running drush updb and drush cex), those diffs struck me as rather "where did this all come from?" (didn't help that the core modules doc hadn't yet list the new modules, though @daffie has since updated it!).

I was unaware till now of a separate "release highlights" in the blog distinct from the regular "release notes", so in the future for 9.x changes I'll definitely check those out. I'm also wondering if some of the changes I thought missing, like #3129043: Move core database drivers to modules of their own and #3173180: Add UI for 'loading' html attribute to images, were essentially part of 9.4.0-alpha1, whose release notes' "All changes since 9.3" section just links to the Gitlab core commit log. Seems like a silly "doh" moment now, but I may have mistakenly interpreted the lack of issues at first glance as somehow basically meaning "no differences from 9.3". Even following that link, though, it seems non-trivial to a) skim what the commits are about (the issue title is truncated or in most cases), b) filter out what's been committed since, and c) filter out what was also committed to earlier branches. I'm sure some CLI git log options on a clone could help with that, and perhaps I'm expecting more than I should from core release notes (I take a bigger grain of salt with contrib), but that's where I was coming from. Thanks again for the quick follow-up!

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Fixed

Understood, thanks for the explanation. :) We might want to get in the habit of linking the full git log always, even when we also list out specific commits from a previous milestone.

xjm’s picture

xjm
she/her
Primary language English
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.