Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
17 Jun 2022 at 20:38 UTC
Updated:
26 Jul 2022 at 17:14 UTC
Jump to comment: Most recent
Comments
Comment #2
john.oltman commentedBranch 3.0.x contains the D9 port for this module that I recently completed. I am trying to get security advisory coverage so I can become the module maintainer, as existing maintainers are generally not responsive. Thank you.
Comment #5
avpadernoThank you for applying! Remember to change status, as in this issue Active says to reviewers not to review the project.
I am crediting the users who reviewed the other application.
Comment #6
john.oltman commentedComment #7
john.oltman commentedThanks @apaderno! I updated status.
Comment #8
LuongGiap commentedHi @john.oltman,
I ran Drupal check , you can review and fix.
Comment #9
LuongGiap commentedI update status
Comment #10
john.oltman commented@LuongGiap this branch requires PHP 8 - does Drupal check support PHP 8 mode and if so did you run it that way? I receive no errors from PHPCS locally.
Comment #11
avpadernoComment #12
avpadernoYes, what reported seems caused by the tool that isn't able to parse the code. For example, the following warning says the tool doesn't recognized typed properties that have been introduced in PHP 7.4.
The line referencing that interface is line 22.
Comment #13
john.oltman commentedHow can we push this forward? Seems to be stuck.
Comment #14
john.oltman commentedBump
Comment #15
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers.