Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#6 Screenshot_20220826_164135.png19.25 KBmauryarahul11
#5 view field-rendered.png92.48 KBshriaas
#3 views_field_view.1.x-dev.rector.patch4.19 KBproject update bot
#3 interdiff-last-bot.6646114.txt667 bytesproject update bot
#2 views_field_view.1.x-dev.rector.patch3.73 KBproject update bot

Issue fork views_field_view-3290481

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new views_field_view.1.x-dev.rector.patch3.73 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6646114.txt667 bytes
new views_field_view.1.x-dev.rector.patch4.19 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
shriaas’s picture

shriaas
Location Pune
commented
Assigned: Unassigned » shriaas
Issue summary: View changes
Issue tags: +Drupal 10 porting day

Picking this up for reviewing

shriaas’s picture

shriaas
Location Pune
commented
Assigned: shriaas » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new view field-rendered.png92.48 KB

I tried enabling the module on D10 and it is working, these are the steps I followed:
1. Cloned the module's code in modules/contrib
2. Applied patch on 8.x-1.x branch
3. Enabled the module
4. Modified content view and added a view field to render people view(I know this is not ideal scenario, was just trying to check if functionality is working).
5 Checked view preview:

Conclusion: basic functionality is working fine after applying the patch. Moving to RTBC.

mauryarahul11’s picture

mauryarahul11
Location Mumbai, India
commented
StatusFileSize
new Screenshot_20220826_164135.png19.25 KB

oops, wrong issue window

project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

smustgrave’s picture

smustgrave commented
Issue summary: View changes

Hello wonder if we can get a D10 release please

nmangold made their first commit to this issue’s fork.

nmangold opened merge request !7

nmangold’s picture

nmangold commented

MR adds support for Drupal 10, and fixes deprecated code in the tests.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Needs work

Thanks for the patch. Added few comments to MR.
Also, hiding files to concentrate on MR.

To test on Drupal 10

1. Add repository to composer.json before main drupal repository.

  "repositories": [
    {
      "type": "vcs",
      "url": "https://git.drupalcode.org/issue/views_field_view-3290481.git"
    },
...

2. Run

composer require drupal/views_field_view:dev-3290481-automated-drupal-10
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs work » Reviewed & tested by the community

Thank you. Ready to go! 🍻
Installable on Drupal 9.4, Drupal 9.5 and Drupal 10.0.1.

roaldnel’s picture

roaldnel commented

Thanks for the work you have done on this! Will this be merged anytime soon by chance? We would really appreciate that...

xem8vfdh’s picture

xem8vfdh commented

thanks everyone for the work, would love to see a release :)

sivakarthik229’s picture

sivakarthik229 commented

Hello,

Will there be a new release for Drupal 10 compatible ?

Thanks
Siva

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

Thanks everyone for your work.
You can install it on your Drupal 10 installation

Either via mglaman/composer-drupal-lenient extension.

OR via composer.json

1. Add repository to composer.json before main drupal repository.

  "repositories": [
    {
      "type": "vcs",
      "url": "https://git.drupalcode.org/issue/views_field_view-3290481.git"
    },
...

2. Run

composer require drupal/views_field_view:dev-3290481-automated-drupal-10
tjtj’s picture

tjtj commented

Please just release this for D10. We should not have to munge with our composer.json files to update.

xem8vfdh’s picture

xem8vfdh commented

I agree with @tjtj, we should have a release on this module here at drupal.org

  • jibran committed 9b036e8f on 8.x-1.x 
    Issue #3290481 by nmangold, Project Update Bot: Automated Drupal 10...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed and pushed to 8.x-1.x.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Created a new release https://www.drupal.org/project/views_field_view/releases/8.x-1.0-beta5

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

Thanks @jibran 🍻

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.