Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new2.62 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0

Status: Needs review » Needs work

The last submitted patch, 2: tamper.1.x-dev.rector.patch, failed testing. View results

project update bot’s picture

Status: Needs work » Needs review
StatusFileSize
new878 bytes
new1.88 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0

sharayurajput’s picture

Assigned: Unassigned » sharayurajput
Issue summary: View changes

I will review this

megachriz’s picture

Status: Needs review » Active

No need to review, changes are already committed. Setting issue status back to "active" for possible future automatic patches.

sharayurajput’s picture

Ok @MegaChriz Thanx

megachriz’s picture

The dev version should be compatible, do you get errors when enabling the module on a Drupal 10 instance? Tests are passing on D10 for Tamper: https://www.drupal.org/pift-ci-job/2432971

Note that this module does nothing on its own. Other modules are needed to make use of it. Feeds Tamper for example does not have compatibility with Drupal 10 yet (because Feeds hasn't either yet). It looks like that ECA: Event - Condition - Action (which has integration with Tamper) does have a Drupal 10 release already. Are you trying Tamper in combination with that?

sharayurajput’s picture

No i don't get ane error while enabling the module on drupal 10
And I haven't try tamper module with combination of an other module

sharayurajput’s picture

Assigned: sharayurajput » Unassigned
project update bot’s picture

mxh’s picture

Issue summary: View changes

Ok, we currently know from #10 that at least there's no error when installing the module in D10. Now we need to know whether it works when being actually used. One possible test could be to use ECA and the ECA Tamper integration, executing some tamper plugins as actions. Using D10, when they don't throw any errors too and still output expected results, then this should be good to go.

megachriz’s picture

@mxh
There is one test failure on PHP 8.1, possibly having something to do with #3280233: Tamper: "Convert to Boolean" If No Match.

Also, I noticed that some Tamper plugins did not implement submitConfigurationForm() correctly. I'm working on fixing that in #3322750: Some plugins do not implement submitConfigurationForm() correctly - Add UI tests (and that one looks like to be ready for commit). Additionally, I discovered that Feeds Tamper doesn't call submitConfigurationForm() on Tamper plugins right now, which may also be causing the issue reported in #3280233: Tamper: "Convert to Boolean" If No Match.

Ideally, all issues noted above are fixed first before creating a D10 compatible release.

mxh’s picture

That's great, thanks for the status summary, highly appreciated.

liam morland’s picture

Status: Active » Fixed

Tamper is currently compatible with Drupal 10.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.