Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#23 interdiff-3289828-17-23.txt2.08 KBfgm
#23 3289828-23.patch7.01 KBfgm
#22 interdiff-3289828-17-22.txt1.73 KBfgm
#22 3289828-22.patch7.03 KBfgm
#21 interdiff-3289828-17-20.txt1.73 KBfgm
#20 3289828-20.patch7.03 KBfgm
#19 interdiff_10-19.txt1.73 KBnkoporec
#19 3289828-19.patch8.88 KBnkoporec
#17 3289828-17-stage-file-proxy-drupal-10.patch6.49 KBrobloach
#16 3289828-stage-file-proxy-drupal-10.patch5.76 KBrobloach
#13 stage_file_proxy.1.x-dev.rector.patch4.85 KBproject update bot
#13 interdiff-last-bot.6675842.txt717 bytesproject update bot
#11 3289828-11.patch8.26 KBmglaman
#10 stage_file_proxy.1.x-dev.rector.patch4.35 KBproject update bot
#10 interdiff-last-bot.6664143.txt506 bytesproject update bot
#8 Screenshot from 2022-08-16 12-53-24.png12.33 KBsharayurajput
#8 Screenshot from 2022-08-16 12-53-33.png24.01 KBsharayurajput
#3 stage_file_proxy.1.x-dev.rector.patch4.81 KBproject update bot
#3 interdiff-last-bot.6645418.txt4.12 KBproject update bot
#2 stage_file_proxy.1.x-dev.rector.patch1.85 KBproject update bot

Issue fork stage_file_proxy-3289828

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new stage_file_proxy.1.x-dev.rector.patch1.85 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6645418.txt4.12 KB
new stage_file_proxy.1.x-dev.rector.patch4.81 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0

balintpekker made their first commit to this issue’s fork.

balintpekker opened merge request !12

sharayurajput’s picture

sharayurajput commented
Issue summary: View changes

I will review this

sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput

I will review this

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
StatusFileSize
new Screenshot from 2022-08-16 12-53-33.png24.01 KB
new Screenshot from 2022-08-16 12-53-24.png12.33 KB

Patch is applied successfully and module is compatible with drupal 10 but when we go to the route config/system/stage_file_proxy getting error - The website encountered an unexpected error. Please try again later.

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
commented

@sharayurajput Could you please provide a little bit more information about the error? I was able to navigate to the page without issue on D9.4, D9.5 and D10.

project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6664143.txt506 bytes
new stage_file_proxy.1.x-dev.rector.patch4.35 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #143

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.0
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 3289828-11.patch8.26 KB

A default issue/commit CI job isn't configured, so uploading a patch to run one manually.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work

Needs work. See MR comments.

project update bot’s picture

project update bot commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-last-bot.6675842.txt717 bytes
new stage_file_proxy.1.x-dev.rector.patch4.85 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1

nkoporec made their first commit to this issue’s fork.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented

Updated the code per @mglaman suggestions, need another review.

robloach’s picture

robloach
he/him
commented
StatusFileSize
new 3289828-stage-file-proxy-drupal-10.patch5.76 KB

This updates the above patch to allow installing the module and loading up the settings screen.

robloach’s picture

robloach
he/him
commented
StatusFileSize
new 3289828-17-stage-file-proxy-drupal-10.patch6.49 KB

Updated with more restrictive dependency list.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

@RobLoach Curious if you were working on this as part of the Drupal 10 Global Porting Day?

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
StatusFileSize
new 3289828-19.patch8.88 KB
new interdiff_10-19.txt1.73 KB

Updated the patch, removed the not used logger service and added the missing app.root service deprecation.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new 3289828-20.patch7.03 KB

nkoporec: the logger is needed to support the inherited $this->logger() function.

Rerolled and added a couple other D10 deprecations: required theme in functional tests, change in Event namespace, @throws, and %app.root% like in patch 19.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new interdiff-3289828-17-20.txt1.73 KB

Sorry, forgot interdiff.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new 3289828-22.patch7.03 KB
new interdiff-3289828-17-22.txt1.73 KB

Rerolled with stark theme instead of removed stable.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new 3289828-23.patch7.01 KB
new interdiff-3289828-17-23.txt2.08 KB

Prevent a runtime failure not caught by tests: typing the logger is not allowed to match the PSR declaration.

project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

smustgrave’s picture

smustgrave commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Running upgrade status module and checking the errors from that patch #23 solves the issue.

Hoping once this gets merged if there can be a release for D10.

Thanks!

ahebrank’s picture

ahebrank commented

With 23 I get an error on drush updatedb after upgrading to D10/drush 11:

Fatal error: Type of Drupal\stage_file_proxy\Commands\StageFileProxyCommands::$logger must be ?Psr\Log\LoggerInterface (as in class Drush\Commands\DrushCommands) in /app/web/modules/contrib/stage_file_proxy/src/Commands/StageFileProxyCommands.php on line 0

Reverting to 22 seems to fix the issue (or the $logger property of the class can probably be removed since it's inherited, I think).

  • greggles committed c939229 on 8.x-1.x 
    Issue #3289828 by Project Update Bot, fgm, balintpekker, nkoporec,...
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Needs work

Thanks for the help, everyone. I've committed this and it should be rolled into development branch shorty.

Moving this back to "Needs work" in case anything more is needed.

Regarding #26, i believe that's a problem with certain versions of php and drush and encourage looking for more information on that. If a fix is needed here that will make this module work more reliably in more environments then that would be helpful. Thanks!

smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

Going to mark fixed for now as I put together a meta for a 2.0.0 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

smustgrave closed merge request !12