Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new2.9 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
Aamir M’s picture

Assigned: Unassigned » Aamir M
Issue summary: View changes
Aamir M’s picture

Assigned: Aamir M » Unassigned
StatusFileSize
new151.51 KB
new56.56 KB
new49.69 KB
new69.68 KB

Verified patch #3 on Drupal 10.0.x and 10.1.x. Patch applied successfully and looks good to me.

Testing Steps:

1. Install drupal 10.0.x and 10.1.x version
2. Install the Restrict IP module (3.x) version and save it in the Module folder
(https://www.drupal.org/node/800874/git-instructions/3.x/nonmaintainer)
3. Open drupal 10 or 10.1 and click on Extend
4. Check the Restrict IP module which unable to install
5. Now apply the patch [Where the Restrict IP module was saved i.e Module folder]
6. Reload the page and again check the Restrict IP module (Note: Clear all caches if required)
7. Now this module is enabled and also install successfully

The module can be installed after applying the patch.
Can be moved to RTBC
RTBC+1

project update bot’s picture

StatusFileSize
new432 bytes
new4.13 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #143

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

anybody’s picture

Assigned: Unassigned » grevil
Issue summary: View changes

Grevil made their first commit to this issue’s fork.

grevil’s picture

Status: Needs review » Needs work

Thank you, @Aamir M! 🙂

I'll do a final check on the basis of patch #6 and do some final phpcs / phpstan cleanup!

grevil’s picture

Title: Automated Drupal 10 compatibility fixes » PHPCS and PHPStan fixes

Alright, we have to establish a new release, as some changes by the Bot are not Drupal 8 compatible.

grevil’s picture

Title: PHPCS and PHPStan fixes » PHPCS, PHPStan and Drupal 10 compatibility fixes
Version: 3.x-dev » 4.x-dev

grevil’s picture

OK, my apologies, there are waaaay too many phpcs problems...

I didn't realize this before, so yea...

This might be impossible to review, so instead just review the commit with the Drupal 10 copatibility problems, when it's pushed. 😅

anybody’s picture

Status: Needs work » Reviewed & tested by the community

Thank you @Grevil, all fine, code looks good. Please merge into 4.x and create a new 4.0.0-beta1 release.
3.x branch should be marked unsupported then.

grevil’s picture

Status: Reviewed & tested by the community » Needs review

Done... felt like refactoring the whole module! 🙂

@Anybody have fun reviewing this! I advise ignoring the first commit "Fixed phpcs issues".

We definitely should publish this as a beta release, as there are so many changes, that it is quite possible something went wrong. Of course I will test the module using Drupal 10 shortly!

anybody’s picture

Status: Needs review » Needs work

@Grevil: Thanks, super awesome work! :)

Just some last changes, especially don't introduce a new dependency, instead use a test dependency for that to be available in the tests. After these changes, this is ready to go!

grevil’s picture

Status: Needs work » Needs review
grevil’s picture

Please review once again.

anybody’s picture

Status: Needs review » Reviewed & tested by the community

Interdiff looks good! We should be careful with 4.x but please make a new release with these important fixes :)

grevil’s picture

Expecting 5 Tests to fail. Let's see if that happens.

grevil’s picture

Status: Reviewed & tested by the community » Fixed

Great now only 4 Tests fail, which are related to #2957482: Parameter must be an array or an object that implements Countable!

  • Grevil committed 2972bf5b on 4.x
    Issue #3289375: PHPCS, PHPStan and Drupal 10 compatibility fixes
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.