Automated Drupal 10 compatibility fixes

I will try to work on that.

I reviewed and applied the remaining necessary changes, so now just need to review it again.

I have done a review and there are some changes in the patch that have to be made:

1) In modal_page/src/Form/ModalForm.php should be used dependency injection to call the service 'extension.path.resolver'in $imagePath = $imageUrl = '/' . \Drupal::service('extension.path.resolver')->getPath('module', 'modal_page') . '/images/';.

2) The service 'extension.path.resolver' was introduced in Drupal 9.3.0 (see: https://www.drupal.org/node/2940438). It means that the core_version_requirement: ^8.8 || ^9 || ^10 should be actually core_version_requirement: ^9.3 || ^10.

3) In modal_page.install file, non static method 'getPath' should not be called statically. It should be changed to \Drupal::service('extension.list.module')->getPath('modal_page')

Hi, I applied patch in #9 for branch 10.0.x and looks great!

Addressed to #7:
1) service 'extension.path.resolver' now is called with dependency injection;
2) core_version_requirement updated to ^9.3 || ^10 as requested;
3) 'getPath' method now is called via the generic \Drupal::service() method.

I found these simple coding standards problems introduced by the patch:

FILE: ...ontrib/try-drupal-10/web/modules/contrib/modal_page/src/Form/ModalForm.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 49 | ERROR | [x] Function comment short description must start with exactly
    |       |     one space
 50 | ERROR | [x] Whitespace found at end of line
 52 | ERROR | [ ] Missing @var tag in member variable comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 150ms; Memory: 16MB

Adding a new patch to fix it.

I know it's not related but as we are going to edit line 88 of modal_page/src/Form/ModalForm.php:
$imagePath = $imageUrl = '/' . $this->extensionPathResolver->getPath('module', 'modal_page') . '/images/';

Assign to both $imagePath and $imageUrl looks kind of weird to me and searches didn't revealed any occurrence of $imagePath usage later on, is there some reason to keep it?

1) Unused use statement use Drupal\Core\Extension\ExtensionPathResolver; in modal_page.install

I applied patch in #13 for branch 4.1.x
Removed use statement use Drupal\Core\Extension\ExtensionPathResolver; in modal_page.install
Used Rector to fix code
Scanned module using "Upgrade Status" found few issues and have attached the screen shots.

Please don't fix any code standard problem in this issue.
It's out of the scope of this issue. Focus on Drupal 10 compatibility only

Im applying a new patch that remove the unused statement.

@reenaraghavan did you applied the patch correctly? When i scan the module using Upgrade Status it does not find any new issues as you can see in the screenshot.

@paulocs, i did all the changes you asked for.

@paulocs, @vitorbsI am new to contributions, and sorry if I have done anything wrong.

You did right @reenaraghavan. Thanks for your contribution :)
Hey @vitorbs, please work on the MR and check if all deprecated code was removed and properly replaced.

Now that @reenaraghavan opened a MR, we should keep working on the MR and not with patches :)

ok, i will work on the MR, thanks!

I fixed the STATUS_PERMANENT deprecated functions that @reenaraghavan found on her scan.

I'll be reviewing this issue.

Hi,
Reviewing this issue took longer than I expected, because I had some problems with the update status module. But everything seems to be right, with no problems reported.
I am attaching two screenshots, with a before/after MR.

Thank you so much for your amazing job, team! I'm updating the target to 5.0.x because I'm going to merge it into 5.0.x with Support to D10

I was going to merge this MR but new fixed were commited into 4.1.x and was necessary to move these fixes to the new version 5.0.x

After merge 4.1.x into 5.0.x this MR needs to be updated because some files were updated and can't be merged because of conflict, for example js/modal-page.js

Now the branch 5.0.x is 100% equal the branch 4.0.x so I'm putting the tag "Needs reroll" and marking as "needs works". If this MR is updated just say here and we can merge for us in the sequence

Thank you so much team

Reroll the patch #22 with 5.0.x

I have reviewed and checked Patch #37 this works for drupal 9.5 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 and Modal page along with the functionality on 10 have been attached for reference:

But the Modal is being displayed for you?

I can install on Drupal 10 but I can't see any Modal pop-up in the page

Steps:

Create a node /test

1. Add a new page at node/add/page
2. Put any title and any body
3. On alias of this node put /test
4. Save

Create a Modal to appear in /test

1. Install at Drupal 10
2. Go to admin/structure/modal/add
3. Fill any title and any body
4. On pages put /test
5. Save

Result

The Modal isn't being displayed in the page /test

So in other words, any Modal is being displayed in the front-end

Error in the console:

Uncaught TypeError: $.removeCookie is not a function

Commenting this line bellow to test the Modal is displayed

// Remove the cookie if show only once option is disabled.
if (show_once != "1") {
  $.removeCookie('hide_modal_id_' + id_modal);
}

I think we need to change from
$.removeCookie('hide_modal_id_' + id_modal);
to
cookies.remove('hide_modal_id_' + id_modal);

Patch with this fix

Moved to the dev branch

Thank all the team that worked on this. You did an awesome job

New release Ready for D10. I put all your names there. If I forgot someone I'm sorry just let me know and I can update this.

Thanks a lot team