Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#7 reroll_diff_5-7.txt839 bytescodebymikey
#7 ape_d10_compatibility-3286083-7.patch6.69 KBcodebymikey
#5 ape_d10_compatibility-3286083-5.patch6.7 KBrahul17
#5 interdiff-3-5.txt1.23 KBrahul17
#5 ape-drupal-check.txt2.6 KBrahul17
#3 ape.1.x-dev.rector.patch5.87 KBproject update bot
#3 interdiff-last-bot.6641603.txt1.1 KBproject update bot
#2 ape.1.x-dev.rector.patch5.49 KBproject update bot

Issue fork ape-3286083

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new ape.1.x-dev.rector.patch5.49 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6641603.txt1.1 KB
new ape.1.x-dev.rector.patch5.87 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
Issue summary: View changes
rahul17’s picture

rahul17 commented
Issue summary: View changes
StatusFileSize
new ape-drupal-check.txt2.6 KB
new interdiff-3-5.txt1.23 KB
new ape_d10_compatibility-3286083-5.patch6.7 KB

I tested patch #3 on drupal 9.5.7 and drupal 10.0.3 and php 8.1 and found below error in Upgrade_status.

Call to undefined method Symfony\Component\HttpKernel\Event\ResponseEvent::isMasterRequest() in Drupal\ape\EventSubscriber\ApeSubscriber->onRespond()

Also patch #3 is not making module Drupal 10 compatible.

I have fixed these issues in new patch. Please review the patch.

Attached file with ignorable drupal-check errors.

tushar1’s picture

tushar1 commented
Status: Needs review » Reviewed & tested by the community

Tested patch #5 on drupal 9.5.7 and drupal 10.0.7 and php 8.1 which is applied cleanly and working as expected, making it RTBC for latest D10 release..

codebymikey’s picture

codebymikey commented
StatusFileSize
new ape_d10_compatibility-3286083-7.patch6.69 KB
new reroll_diff_5-7.txt839 bytes

Rerolled patch #5 because the presence of the original version: 8.x-1.0 is commented out when installed with composer.

P.S. it seems D.O tests are disabled for the 8.x branch.

thalles made their first commit to this issue’s fork.

thalles opened merge request !1

navneet0693’s picture

navneet0693 commented
Status: Reviewed & tested by the community » Needs work 
+++ b/ape_test/ape_test.info.yml
@@ -1,6 +1,6 @@
+core_version_requirement: ^8 || ^9 || ^10

We should remove Drupal 8 support.

sakthi_dev made their first commit to this issue’s fork.

sakthi_dev’s picture

sakthi_dev commented
Status: Needs work » Needs review

Please review.

navneet0693’s picture

navneet0693 commented
Status: Needs review » Needs work

@sakthi_dev One small suggestion, rest is good to go !

codebymikey’s picture

codebymikey commented
Status: Needs work » Needs review
navneet0693’s picture

navneet0693 commented

I have added few more improvements at https://github.com/navneet0693/ape, if some requires more improved coding standards support.

steel-track’s picture

steel-track commented

I am not doing much Drupal development these days so I am looking for a new maintainer of this module. If anyone is interested please reach out. Thanks!

codebymikey’s picture

codebymikey commented

Yeah sure, I'm down to maintain and get this over the line.

steel-track’s picture

steel-track commented

@codebymikey and @navneet0693: I've given you both maintainer permissions. Thank you for taking this on! If you have questions on the design of this module, feel free to ping me.

codebymikey’s picture

codebymikey commented
Status: Needs review » Fixed
navneet0693’s picture

navneet0693 commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.