Problem/Motivation

There is a button and a link on the wrong position on the Claro theme (one under the job items at the end of the page and one under sources directly under the search filters)

Screenshot which shows the wrong position of the link 'preview'

screenshot of wrong position from the 'request translation' button under TMGMT - Sources

Proposed resolution

The Button 'request translation' should be placed lower (same hight than the dropdowns and not like the labels) and with a margin to the left.
The 'preview' link should also be placed lower (same hight than the text on the buttons left and right).

CommentFileSizeAuthor
#8 Screenshot_TMGMT-Source-Operations_Checkbox_CLARO-MOBILE.png9.89 KBromina_ferrario
#8 Screenshot_TMGMT-Source-Operations_Checkbox_SEVEN-MOBILE.png8.89 KBromina_ferrario
#8 Screenshot_TMGMT-Source-Operations_Checkbox_CLARO-DESKTOP.png8.8 KBromina_ferrario
#8 Screenshot_TMGMT-Source-Operations_Checkbox_SEVEN-DESKTOP.png7.74 KBromina_ferrario
#8 Screenshot_TMGMT-Source_RequestTranslation_CLARO-MOBILE.png7.35 KBromina_ferrario
#8 Screenshot_TMGMT-Source_RequestTranslation_SEVEN-MOBILE.png12.78 KBromina_ferrario
#8 Screenshot_TMGMT-Source_RequestTranslation_CLARO-DESKTOP.png9.18 KBromina_ferrario
#8 Screenshot_TMGMT-Source_RequestTranslation_SEVEN-DESKTOP.png11.35 KBromina_ferrario
#8 Screenshot_TMGMT-Source_classNameDouble-_CLARO.png10.75 KBromina_ferrario
#8 Screenshot_TMGMT-Source_classNameSingle-_SEVEN.png11 KBromina_ferrario
#8 Screenshot_TMGMT-JobItems-ReviewJob_Links-PreviewAbort_CLARO-HOVER.png8.38 KBromina_ferrario
#8 Screenshot_TMGMT-JobItems-ReviewJob_Links-PreviewAbort_SEVEN-HOVER.png7.87 KBromina_ferrario
#8 Screenshot_TMGMT-JobItems-ReviewJob_Links-PreviewAbort_CLARO.png8.46 KBromina_ferrario
#8 Screenshot_TMGMT-JobItems-ReviewJob_Links-PreviewAbort_SEVEN.png8.64 KBromina_ferrario
#8 tmgmt_3285822_8_fixLinksAndButtonCLARO_fixCheckox.patch3.26 KBromina_ferrario
#4 Screenshot_TMGMT-Source_requestTranslation_fixedPosition_16-06-2022.png9.65 KBromina_ferrario
#4 Screenshot_TMGMT-JobItem_ButtonsAndLinks_fixedStyle-HoverAbort_16-06-2022.png7.85 KBromina_ferrario
#4 Screenshot_TMGMT-JobItem_ButtonsAndLinks_fixedStyle-hoverPreview_16-06-2022.png8.46 KBromina_ferrario
#4 Screenshot_TMGMT-JobItem_ButtonsAndLinks_fixedStyle_16-06-2022.png14.79 KBromina_ferrario
#4 tmgmt_14562592_4_claro_fixPositionAndStylingOfRequestTranslationButtonAndPreviewAndAbortLink.patch1.68 KBromina_ferrario
Screenshot_TMGMT-Source_RequestTranslation_15-06-2022.png19.33 KBromina_ferrario
Screenshot_TMGMT-JobItem_ButtonsAndLink_15-06-2022.png17.8 KBromina_ferrario

Comments

romina_ferrario created an issue. See original summary.

romina_ferrario’s picture

romina_ferrario commented
Assigned: Unassigned » romina_ferrario
romina_ferrario’s picture

romina_ferrario commented
Issue summary: View changes
romina_ferrario’s picture

romina_ferrario commented
StatusFileSize
new tmgmt_14562592_4_claro_fixPositionAndStylingOfRequestTranslationButtonAndPreviewAndAbortLink.patch1.68 KB
new Screenshot_TMGMT-JobItem_ButtonsAndLinks_fixedStyle_16-06-2022.png14.79 KB
new Screenshot_TMGMT-JobItem_ButtonsAndLinks_fixedStyle-hoverPreview_16-06-2022.png8.46 KB
new Screenshot_TMGMT-JobItem_ButtonsAndLinks_fixedStyle-HoverAbort_16-06-2022.png7.85 KB
new Screenshot_TMGMT-Source_requestTranslation_fixedPosition_16-06-2022.png9.65 KB

fixed the styling of the preview and abort links (now shown as action link and danger action link) under job items -> review job

Preview and Abort links styled as action and danger action link

hoverstate of preview link
hoverstate of danger abort link

also fixed the position of the request translation button under sources

'request translation' button now on the right place

romina_ferrario’s picture

romina_ferrario commented
Assigned: romina_ferrario » Unassigned
romina_ferrario’s picture

romina_ferrario commented
Status: Needs work » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Please also include screenshots of seven to see if it has a negative impact there.

As communicated, we also need to adjust the form item classes and support both single and double -.

Additionally, there's one more feature to consider here. On the job page, create a continuous job, then visit the source page again. There's a new button and next to it a checkbox that also looks quite off. We should check if we can improve that a bit as well, make sure to also check that we don't break it in seven.

romina_ferrario’s picture

romina_ferrario commented
StatusFileSize
new tmgmt_3285822_8_fixLinksAndButtonCLARO_fixCheckox.patch3.26 KB
new Screenshot_TMGMT-JobItems-ReviewJob_Links-PreviewAbort_SEVEN.png8.64 KB
new Screenshot_TMGMT-JobItems-ReviewJob_Links-PreviewAbort_CLARO.png8.46 KB
new Screenshot_TMGMT-JobItems-ReviewJob_Links-PreviewAbort_SEVEN-HOVER.png7.87 KB
new Screenshot_TMGMT-JobItems-ReviewJob_Links-PreviewAbort_CLARO-HOVER.png8.38 KB
new Screenshot_TMGMT-Source_classNameSingle-_SEVEN.png11 KB
new Screenshot_TMGMT-Source_classNameDouble-_CLARO.png10.75 KB
new Screenshot_TMGMT-Source_RequestTranslation_SEVEN-DESKTOP.png11.35 KB
new Screenshot_TMGMT-Source_RequestTranslation_CLARO-DESKTOP.png9.18 KB
new Screenshot_TMGMT-Source_RequestTranslation_SEVEN-MOBILE.png12.78 KB
new Screenshot_TMGMT-Source_RequestTranslation_CLARO-MOBILE.png7.35 KB
new Screenshot_TMGMT-Source-Operations_Checkbox_SEVEN-DESKTOP.png7.74 KB
new Screenshot_TMGMT-Source-Operations_Checkbox_CLARO-DESKTOP.png8.8 KB
new Screenshot_TMGMT-Source-Operations_Checkbox_SEVEN-MOBILE.png8.89 KB
new Screenshot_TMGMT-Source-Operations_Checkbox_CLARO-MOBILE.png9.89 KB

adjusted the form item classes to support both single and double -.

Also fixed styling for this checkbox for desktop and mobile (on seven and claro).

Additionally fixed now the 'request translation' button position also on mobile.

To not affect seven that much i changed also again the look from the links a bit (would no longer change 'preview' and 'abort' but only 'preview').

Here you can see how it will look with the patch on seven and on claro:

Seven Claro
Job Items: links 'preview' and 'abort' screenshot of links 'preview' and 'abort' on seven screenshot of links 'preview' and 'abort' on claro
Job Items: links 'preview' and 'abort' (hover) screenshot of links 'preview' and 'abort' on seven (hover) screenshot of links 'preview' and 'abort' on Claro (hover)
support single and double - screenshot of style with class names with single - screenshot of style with class names with double -
'request translation' button position (desktop) screenshot of 'request translation' button position on seven desktop screenshot of 'request translation' button position on claro desktop
'request translation' button position (mobile) screenshot of 'request translation' button position on seven mobile screenshot of 'request translation' button position on claro mobile
operations checkbox position (desktop) screenshot of operations checkbox style on seven desktop screenshot of operations checkbox style on claro desktop
operations checkbox position (mobile) screenshot of operations checkbox style on seven mobile screenshot of operations checkbox style on claro mobile
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

  • Berdir committed b058db7 on 8.x-1.x 
    Issue #3285822 by romina_ferrario: Claro: wrong position of 'preview'...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.