Problem/Motivation

Phan scan catch an error on PHP8 version

Expected an object instance when accessing an instance property, but saw an expression $file with type bool on plupload/plupload.module line 239
Expected an object instance when accessing an instance property, but saw an expression $file with type bool on plupload/plupload.module line 240

Steps to reproduce

Run phan scan- on PHP8

Proposed resolution

Seems that error in annotaion in https://git.drupalcode.org/project/plupload/-/blob/7.x-1.7/plupload.modu... function should return object because variable $wrapper never used https://git.drupalcode.org/project/plupload/-/blob/7.x-1.7/plupload.modu...

CommentFileSizeAuthor
#5 plupload_3285416.patch558 bytesastonvictor

Issue fork plupload-3285416

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Andrei Haurukovich created an issue. See original summary.

Andrei Haurukovich’s picture

Issue summary: View changes

Andrei Haurukovich’s picture

Status: Active » Needs review
astonvictor’s picture

StatusFileSize
new558 bytes
budalokko’s picture

Version: 7.x-1.7 » 7.x-2.x-dev

budalokko’s picture

Status: Needs review » Fixed

Committed to 7.x-2.x-dev. Thanks !

budalokko’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.