It is difficult to read and understand code right now due to wrong coding standards. All the should be fixed for further development of the module.

Issue fork magento-3285287

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gaurav.kapoor created an issue. See original summary.

Johnny Santos’s picture

Johnny Santos commented
Assigned: Unassigned » Johnny Santos

Hey, I'm going to give it a try with the cs

gaurav.kapoor’s picture

gaurav.kapoor commented

Go ahead, @Johnny Santos. This link has all the details related to fixing coding standard issues in a Drupal module -> https://www.drupal.org/docs/contributed-modules/code-review-module/php-c...

Johnny Santos opened merge request !5

Johnny Santos’s picture

Johnny Santos commented
Assigned: Johnny Santos » Unassigned

Hi, CS its done.
fixing the issue I could see that it stills returns the need of dependency injection on line 1083 and 1084.
Since its out of scope, I did only whats asked.
I would gladly create the dependency injections if another issue its created, I will follow here for answers.

Johnny Santos’s picture

Johnny Santos commented
Status: Active » Needs review
WagnerMelo’s picture

WagnerMelo commented
Assigned: Unassigned » WagnerMelo

Hello, i'll review this issue.

WagnerMelo’s picture

WagnerMelo commented
Assigned: WagnerMelo » Unassigned
Status: Needs review » Reviewed & tested by the community

I reviewed it, and everything looks fine, i think that @johnnySantos, could solve all the errors.
So i'll move this issue to RTBC

omkar-pd made their first commit to this issue’s fork.

omkar-pd’s picture

omkar-pd commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.