Problem/Motivation

In #3282982: Simplify the scheduler plugin implementations two separate bugs were introduced when generating the form ids used in hook_form_alter. These faults were not picked up in automated tests because the entity type form is not covered in any Scheduler functional tests.

Proposed resolution

Add a test

Issue fork scheduler-3285242

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055 opened merge request !52

jonathan1055’s picture

jonathan1055 commented
Title: Add test coverage for entity type form » 3285242-entity-type-form-test

As expected, all tests pass. Now add test coverage for the entity type form. All cases in the new test should fail.

jonathan1055’s picture

jonathan1055 commented
Title: 3285242-entity-type-form-test » Add test coverage for entity type form
Status: Active » Needs review

As expected all 12 test data cases (4 entities x 3 operation) failed. Now fix the first bug, re-doing this commit from #22

jonathan1055’s picture

jonathan1055 commented

Now there are just 3 test case failues, the "add first" scenario for node, media and taxonomy_term. Interestingly the commerce_product entity type passes already (that's not a problem, though).

Next commit will fix the second bug.

  • jonathan1055 committed 41076cb on 2.x 
    Issue #3285242 by jonathan1055: Add test coverage for entity type form
jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Fixed

Done

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

jonathan1055 commented
Parent issue: » #3452911: [meta] 2.x test coverage