Problem/Motivation

Sometimes you have certain order types where taxes do not apply. Currently, you can only disable tax calculations globally. It would be helpful if this were configurable per order type.

Proposed resolution

Add a setting to the order type that determines whether the tax applies.

CommentFileSizeAuthor
#9 3284780_9.patch9.71 KBalexdoma
#8 3284780_8.patch9.88 KBalexdoma
#3 disable-at-order-type-3284780-3.patch10.1 KBtomtech
#2 disable-at-order-type-3284780-2.patch10.12 KBtomtech

Comments

TomTech created an issue. See original summary.

tomtech’s picture

tomtech commented
Status: Active » Needs review
StatusFileSize
new disable-at-order-type-3284780-2.patch10.12 KB

The attached patch allows the disable_tax_calculation property to be applied at the order type level, in addition to globally.

tomtech’s picture

tomtech commented
StatusFileSize
new disable-at-order-type-3284780-3.patch10.1 KB

Inverts the logic so that it is an enable option, rather than a disable option.

rszrama’s picture

rszrama commented
Issue tags: +Prague2022
rinasek’s picture

rinasek commented
Issue tags: -Prague2022 +KickstartPrague2022
rinasek’s picture

rinasek commented
jsacksick’s picture

jsacksick commented
Status: Needs review » Postponed

This was discussed while in Prague, and I'm more in favor of adding conditions support to tax types. (See #2424487: Add condition support for commerce_tax_type entity type).

Postponing this for now.

alexdoma’s picture

alexdoma commented
StatusFileSize
new 3284780_8.patch9.88 KB

re-roll for drupal 9.5.x

alexdoma’s picture

alexdoma commented
StatusFileSize
new 3284780_9.patch9.71 KB

set correct paths, re-roll for drupal 9.5.x