Problem/Motivation
Make the 2.0.x branch compatible with Drupal 10.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Issue fork config_split-3284552
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3284552-drupal-10-compatibility
changes, plain diff MR !27
Comments
Comment #3
benjifisherI installed the Upgrade Status module. According to its report, this module just needs an update to the
.info.ymlfile.I ran
phpstanlocally. It did not find any problems.I ran the PHPUnit tests, and they showed deprecation errors related to the change record $modules is now a protected property in tests.
I opened a merge request to fix the problems I found.
I also checked coding standards. There are several arrays that extend beyond Column 80. CodeSniffer does not find any other problems. If you would like to fix those as part of this issue, I can update the MR.
Comment #4
bircherThanks!
Yes I will run tests on D10.x and then release a stable version.
Don't worry about the long arrays, they are excluded from phpcs:
https://git.drupalcode.org/project/config_split/-/blob/2.0.x/phpcs.xml.d...
I find it more readable the way it is now.
Comment #5
benjifisherI am updating the title to distinguish this issue from #3293759: Drupal 10 compatibility (1.x branch).
Comment #6
benjifisherOops, I updated the tag instead of the title.
Comment #8
bircherI guess we can open another issue in case this doesn't fix it even though tests pass now.
Comment #9
bircher