Frontend (Olivero + Claro) - June 7 2022 Meeting in Slack

This frontend meeting is a combo meeting for the Olivero and Claro themes. This meeting takes place every Tuesday at 3pm UTC (8:30pm IST, 5pm CEST, 11am EST, 8am PST). See Time.is to see what that is in your timezone.

The meetings are held using Slack threads in the #frontend Slack channel on drupal.slack.com.

UPDATED (transcript added)

Introductions (Please include your drupal.org name to make crediting easier!)
11 replies

andy-blum
katannshaw
cindytwilliams
tinto
nicklewisatx
ckrina
mherchel
javi-er
ujjwalahluwalia
lauriii
markconroy

***

What agenda items would you like to discuss today?
0 replies

***

Any further general updates from the maintainers or product managers?
4 replies

mherchel
Don't have too much from the Olivero side of things. We had one issue committed earlier today (https://www.drupal.org/project/drupal/issues/3223264)
Olivero: Messages can be malformed when JS creates messages and PHP messages already exist

mherchel
I've also made some progress trying to get UC Browser support out of core :slightly_smiling_face: https://www.drupal.org/project/drupal/issues/3251384
[Policy, small patch] Remove support for UC Browser

mherchel
and not quite Olivero related, but I'm submitting a patch for EU cookie compliance module to give it an option to extend Olivero's look and feel https://www.drupal.org/project/eu_cookie_compliance/issues/3215739
image.png
Create option to apply styles that extend Olivero theme's look and feel

mherchel
I'm excited about that

***

Where can contributors help this week?
19 replies

katannshaw
Note: If you want your item added to a new topic thread, add a thread icon with it

mherchel
I would love it if anyone knows how we can proceed with https://www.drupal.org/project/drupal/issues/3172696
Search API-made exposed forms are not styled within Olivero

mherchel
I want to get that done, but don't have a clue where or how to go

lauriii
https://www.drupal.org/project/drupal/issues/3085219 could use review
Redesign Installer

Tinto
I worked on two issues that @deviantintegral mentioned in last week’s meeting. Both patches passed testing, but not sure what the next steps are. Could someone please give these a glance or review perhaps?
https://www.drupal.org/project/drupal/issues/3281451
https://www.drupal.org/project/drupal/issues/3281438

deviantintegral
If anyone is looking for backend / PHP issues, we have a list at https://www.drupal.org/project/drupal/issues/3278124#comment-14531548. In particular, the "Small" issues would be great for a new Drupal developer because the actual changes should be very small so they could spend more time learning about running tests themselves. (edited)
Convert various tests that use bartik/seven to olivero/claro

deviantintegral
On the CKEditor one, is catch asking for someone to post a backport of the patch? mildly confused to see him RTBC it :smile:

deviantintegral
The other one just needs eyes

mherchel
:eye: :eye:

mherchel
done

Tinto
I don’t understand @catch’s comment on the CKEditor one either.. These are strictly D10 issues, no?

deviantintegral
That was my thought too.

catch
Olivero is in 9.x, so we should backport test changes where we can to keep 9.x and 10.x in sync (for later bugfixes etc.)

catch
A lot of these will just cherry-pick between branches and don't need an explicit 9.4/9.5 patch.

catch
With bartik/seven specifically, we can't deprecate them in 9.4/9.5 while they're used in non-legacy tests, because we'll get failures due to deprecation errors being triggered, so we actually do need to backport.

Tinto
Thanks @catch. How to determine which ones need a backport?

Tinto
I could use some help with this one
https://www.drupal.org/project/drupal/issues/3281429
Update Block non-Migration tests to not use Bartik and Seven

catch
@Tinto probably all of the bartik/seven test issues need to be backported.

catch 6 days ago
Worth asking in #d10readiness about https://drupal.slack.com/archives/C0D5GJZ8B/p1654617199003489?thread_ts=...

Tinto
I could use some help with this one
https://www.drupal.org/project/drupal/issues/3281429

***

Continue the conversation in Slack. Thank you for showing up and contributing!
If you have additional questions or comments, please post them here or on the meeting agenda issue: https://www.drupal.org/project/drupal/issues/3284441.
16 replies

Kristen Pol (she/her) 18 hours ago
@katannshaw I didn't notice this in the core calendar. Is this something that should be added?
Screen Shot 2022-06-13 at 12.39.03 PM.png

katannshaw 18 hours ago
Sure. I’m not sure how to add it there quite honestly.

Kristen Pol (she/her) 18 hours ago
@hestenet (he/him) Would you be able to add core calendar access for @katannshaw to add this event please :slightly_smiling_face: ?

Kristen Pol (she/her) 18 hours ago
I think once you have access, then it's just like adding any other Google calendar event, but you just choose the "Drupal Core" calendar

katannshaw 18 hours ago
Ok great, thank you.

Kristen Pol (she/her) 18 hours ago
:thumbsup:

hestenet (he/him) 17 hours ago
Can do! :slightly_smiling_face:

katannshaw 16 hours ago
@Kristen Pol (she/her) @hestenet (he/him) Do you think it would be a problem for me to delete the old Olivero (Mondays) and Claro (Wednesdays) meetings created by Gabor? I don’t want to add confusion by adding another frontend meeting

katannshaw 16 hours ago
I’m thinking so; just feels weird to delete someone else’s calendar event

hestenet (he/him) 16 hours ago
If they're definitely no longer active, I'ms ure it would be fine - but you could always give Gabor a ping to check.

katannshaw 16 hours ago
Ok. @Gábor Hojtsy (he/him) are you up? If so are you cool with this? ^^

katannshaw 16 hours ago
Ok I’ll go ahead and do it and ask for forgiveness later. Thanks all.

katannshaw 16 hours ago
Ok it’s done. Thanks again. @ckrina FYI ^^

Kristen Pol (she/her) 15 hours ago
Thanks! Best to not have events there that aren't happening :slightly_smiling_face:

Gábor Hojtsy (he/him) 7 hours ago
@katannshaw totally, if any other events are definitely not happening anymore, please delete them :)

katannshaw 39 minutes ago
I made the change yesterday afternoon so it should be all good now. Thanks for everything, including pointing it out @Kristen Pol (she/her)!