In PHP 8.0 Deprecation warnings arise in case of required parameter follows optional in function declaration:

Deprecated: Required parameter $options follows optional parameter $data in /modules/contrib/commerce/modules/cart/commerce_cart.module on line 1163

Deprecated: Required parameter $name follows optional parameter $data in /modules/contrib/commerce/modules/cart/commerce_cart.module on line 1163

CommentFileSizeAuthor
#7 commerce_core_cart-php8_deprecation_3284128#7.patch517 bytesfloris vedder
#2 commerce_core_cart-php8_deprecation_3284128.patch830 bytesNatallia

Comments

Natallia created an issue. See original summary.

Natallia’s picture

Natallia commented
StatusFileSize
new commerce_core_cart-php8_deprecation_3284128.patch830 bytes
Natallia’s picture

Natallia commented
Status: Active » Needs review
heni_deepak’s picture

heni_deepak commented

I also facing the same issue.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Deprecated: Required parameter $options follows optional parameter $data in commerce_cart.module » Required parameter $options follows optional parameter $data in commerce_cart.module
Assigned: Natallia » Unassigned
Status: Needs review » Needs work
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Required parameter $options follows optional parameter $data in commerce_cart.module » Required parameter $options follows optional parameter $data in commerce_cart.module on line 1163
floris vedder’s picture

floris vedder commented
StatusFileSize
new commerce_core_cart-php8_deprecation_3284128#7.patch517 bytes

Made an adjustment to the patch so the path is based on the root of the contrib module.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
rszrama’s picture

rszrama commented
Status: Needs review » Fixed

No clue why we ever even had an optional first parameter on this callback. Doesn't appear we did that for the other custom metadata callbacks. Patch is great, thanks!

  • rszrama committed bcf9cb6 on 7.x-1.x authored by Natallia 
    Issue #3284128 by Natallia, Floris Vedder: Required parameter $options...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Could one of the maintainers please tag a new release with this fix included? Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bserem’s picture

bserem commented

A new release including this one is still pending

neeraj420’s picture

neeraj420 commented

after applying the patch I am getting the following error

Error: Call to undefined function commerce_product_reference_get_default_product() in commerce_cart_field_formatter_view() (line 2763 of /website/sites/all/modules/commerce/modules/cart/commerce_cart.module).

kindly help.
Thanks in advance