Problem/Motivation

https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/modules/loca...

See http://drupalcode.org/project/drupalorg.git/blob/refs/heads/7.x-3.x:/drupalorg_project/plugins/release_packager/DrupalorgProjectPackageRelease.class.php#l219

This url has been changed, the class file is here currently:

https://git.drupalcode.org/project/drupalorg/-/blob/7.x-3.x/drupalorg_project/plugins/release_packager/DrupalorgProjectPackageRelease.class.php

Steps to reproduce

Proposed resolution

Remove the out of date link

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#16 3283558-16.patch5.37 KBsahil.goyal
#13 locale_build_comment.png403.77 KBroberttabigue
#11 interdiff-8-11.txt4.25 KBrassoni
#11 3283558-11.patch5.37 KBrassoni
#8 interdiff_5-8.txt527 bytesmrinalini9
#8 3283558-8-remove.patch777 bytesmrinalini9
#5 3283558-5-remove.patch778 bytesandregp
#5 3283558-5-replace.patch939 bytesandregp

Issue fork drupal-3283558

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Pasqualle created an issue. See original summary.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

This is the current line number (241)
https://git.drupalcode.org/project/drupalorg/-/blob/7.x-3.x/drupalorg_pr...

But I guess it would be better to remove this code comment, than to fix it every time the drupalorg project code is changed.

Meeni_Dhobale made their first commit to this issue’s fork.

cilefen’s picture

cilefen commented
Issue tags: +Novice, +Documentation
andregp’s picture

andregp commented
Status: Active » Needs review
StatusFileSize
new 3283558-5-replace.patch939 bytes
new 3283558-5-remove.patch778 bytes

I did two patches, one replacing the comment link, the other removing (as @Pasqualle also suggested).

gayatri chahar’s picture

gayatri chahar commented

I applied patch #5 against 9.5.x and both patch is working
One is in replace and second is it to remove
Thanks @andregp

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs review » Needs work

The remove patch should also remove the next line
* for how the version strings are created.

I would go with the link removal patch.

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new 3283558-8-remove.patch777 bytes
new interdiff_5-8.txt527 bytes

Hi,

I have updated patch #5 (remove patch) by removing the line as mentioned in #7, please review it.

Thanks & Regards,
Mrinalini

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 3283558-8-remove.patch, failed testing. View results

rassoni’s picture

rassoni commented
Status: Needs work » Needs review
StatusFileSize
new 3283558-11.patch5.37 KB
new interdiff-8-11.txt4.25 KB

Fixed Failed Command #11
Added Interdiff

vinmayiswamy’s picture

vinmayiswamy commented

I applied #11 patch against 9.5.x-dev and its applied cleanly.

Thanks @Rashmisoni

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new locale_build_comment.png403.77 KB

Hi @Pasqualle,

I reviewed Patch #11 and confirmed it looks good to me and is updated.

Please see attached screenshot.

Thanks.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 3283558-11.patch, failed testing. View results

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sahil.goyal’s picture

sahil.goyal commented
StatusFileSize
new 3283558-16.patch5.37 KB

rerolling the patch will more compatible with 10.1.x

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Version: 10.1.x-dev » 9.5.x-dev

Please continue with patch in #8, all other changes are unrelated to the reported problem.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

created separate issue #3323057: Invalid PHPDoc comments for the problems found in comment #11

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs work » Reviewed & tested by the community

I have no idea why patch #8 is failing to test. It is just a comment removal, and looks good to me.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Sent #8 for a retest against 9.5.x and 10.1.x, I agree that #11 onwards is out of scope here.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Looks like this needs a phpstan baseline update.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

Not sure what that means, but both tests passed now.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone made their first commit to this issue’s fork.

quietone opened merge request !9320

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Needs review

Converted #8 to an MR. See #9 where it was RTBC'ed

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a straight forward enough fix.

nod_ closed merge request !9320

  • nod_ committed b322a83f on 11.x 
    Issue #3283558 by andregp, mrinalini9, Rassoni, meeni_dhobale, sahil....
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Fixed

Committed b322a83 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.