Problem/Motivation

The delete button on Reorder Children page is may be misleading.

Users may believe that hitting the Delete button this page will remove the entity as a child of the page in context, however it actually links to the delete page of the child.

It seems unlikely, and rarely useful that the delete button would actually be used for its current purpose.

As discussed externally, I proposed either removing the Delete button entirely, or making use of Drupals hook_entity_operation() to populate the Operations column.

Proposed resolution

Remove the Delete button from Reorder Children page.

Remaining tasks

  • Implement.
  • Update tests if required.

User interface changes

-1 button, leaving edit button (if user has permission to edit).

API changes

Nil

Data model changes

Nil

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dpi created an issue. See original summary.

dpi’s picture

A more complex option could be actually changing the Delete button to nullify the parent field value of the child entity.

dpi’s picture

Assigned: dpi » Unassigned
Status: Active » Needs review

Failures seem unrelated: #3283072: Fix tests with MRs

larowlan made their first commit to this issue’s fork.

  • larowlan committed d7f81ba on 3.x authored by dpi
    Issue #3283067 by dpi: Remove delete button from Reorder Children page
    
larowlan’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.