[D9] Toggle Logger Channels

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

Since the project is being used for this application, for the time this application is open, only the user who created the application can commit code.

• What follows is a quick review of the project; it doesn't mean to be complete
• Each review point doesn't show all the lines that should be changed; it shows a single example of what is wrong in the code
• The review points are about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; they aren't listed in any particular order, not even in order of importance

/**
   * @return mixed
   */
  private function getLogChannels() {
    $database = \Drupal::database();
    $query = $database->select('watchdog', 'w');

    return $query->fields('w', ['type'])->distinct(true)
      ->execute()->fetchAll();
  }

Dependencies need to be injected in the create() method.

public function log($level, $message, array $context = []) {
    return true;
  }

  /**
   * {@inheritDoc}
   */
  public function info($message, array $context = []) {
    return true;
  }

The first method is missing the documentation comment; the other methods are returning the wrong value.

public function setContainer(ContainerInterface $container = NULL) {
  parent::setContainer($container);
}

A method that just calls the method defined from the parent class can be removed.

  /**
   * Tests that the home page loads with a 200 response.
   */
  public function testLoad() {
    $this->drupalGet(Url::fromRoute('<front>'));
    $this->assertSession()->statusCodeEquals(200);
  }

The test isn't testing the module, since it doesn't alter the front page. Furthermore, Drupal core already tests the front page load; there is no need for every module to repeat that test, since the Drupal core tests are executed when a module's test are executed.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.