Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 May 2022 at 09:45 UTC
Updated:
9 Jun 2022 at 13:04 UTC
Jump to comment: Most recent
Comments
Comment #2
alanhdev commentedI've raised a minor issue https://www.drupal.org/project/layout_paragraphs_toggle_publish/issues/3... as the .idea folder appears in the repo and needs to be removed.
Comment #3
t-loInitial code review:
In your class TogglePublish function getPublishStatusLink:
$published = !empty($entity) ? $entity->isPublished() : FALSE;
could be reduced to:
$published = !empty($entity) && $entity->isPublished();
Unused use statements in the module file:
use Drupal\Core\Link;
use Drupal\Core\Url;
Comment #4
avpadernoThank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smother review.
To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.
Since the project is being used for this application, for the time this application is open, only the user who created the application can commit code.
Comment #5
avpadernoReviews are for reporting an incorrect use of the Drupal API, code that doesn't follow the coding standards, or code that isn't secure. We don't point out other issues, except in the case a PHP file is full of syntax errors, or contains code outside a class/function/method.
Comment #6
avpadernocore_version_requirementis recognized starting from Drupal 8.8.x, if I recall correctly. That means the line should becore_version_requirement: ^8.8 || ^9.Comment #7
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thank you to all the reviewers.
Comment #8
t-loCompleted initial review.
No Licencing issues found, all code is custom.
No other modules with duplicated functionality.
Drupal code standards met, small code style points reported in comment #3
Comment #9
xaviemirmonThank you all for your feedback, I'll apply those changes now.