Problem/Motivation

Looks like #3225966: Consider loosening our constraint to allow sites to install Guzzle 6 or 7, or otherwise handle PHP 8.1 deprecations for Guzzle 6 didn't include a composer update drupal/core which makes 9.4.x-dev and 9.5.x-dev HEAD failing on PHP 7.3 with

1) Drupal\Tests\ComposerIntegrationTest::testComposerLockHash
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'232d135ecf054a91a09ed87d08d5d200c2e11a6a'
+'5ee7c279ca3cbef8b2ba2c3a7ebe7fb78dee9b7c'

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3282050-2.patch841 bytesspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3282050-2.patch841 bytes
mondrake’s picture

mondrake
Location 🇮🇹
commented
Priority: Normal » Critical

Isn't this a critical?

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review

> Isn't this a critical?

Well, seems to be broken for ~4 days, so not _that_ critical ;) But I think you're right.

daffie’s picture

daffie commented
Status: Needs review » Needs work

The testbot is not happy with PHP 8.1, maybe because Guzzle 6 does not support PHP 8.1

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Looks like PHP 8.1 TestBot has been hit twice by stuff like

00:46:34.321      error: [
00:46:34.321        'JavaScript stack:',
00:46:34.321        'ReferenceError: jQuery is not defined',

in Nightwatch tests, which doesn't look like Guzzle related. I'll trigger a retest, but I think it's not related to this issue.

Insta-Edit: Also PHP8.1 passes on 9.4.x, another reason for me to believe the 9.5.x failures are a fluke

cilefen’s picture

cilefen commented

Is that one #3281863: Nightwatch tests failing >50% of test runs on PHP 7.3 in 9.4.x and 9.5.x, as well as PHP 8.1 on 10.0.x?

spokje’s picture

spokje
Primary language Dutch
commented

@cilefen: Thanks.

Weirdly the Nightwatch failures I encounter in this issue are on the PHP 8.1 Testbot, not the PHP 7.3 ones. Otherwise it fits.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Looks good let's get this in on 9.4.x and 9.5.x

  • catch committed d851e0c on 9.5.x 
    Issue #3282050 by Spokje: Failing HEAD on PHP 7.3 on...

  • catch committed ac0d6c6 on 9.4.x 
    Issue #3282050 by Spokje: Failing HEAD on PHP 7.3 on...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.5.x and cherry-picked to 9.4.x., thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.