Problem/Motivation

When changes from the default icon to the other, it is very difficult.
As previously described in #3198770: Add template for the icon, need to rewrite whole Drupal.extlink.applyClassAndSpan to customize icon HTML output on current implementation.

Proposed resolution

Implement icon HTML output using Drupal.theme() JavaScript functions.
If defines icon HTML output on Drupal.theme(), it is easier to override HTML output from an other theme, no need to rewrite whole Drupal.extlink.applyClassAndSpan().

CommentFileSizeAuthor
#2 3281593-2.patch8.5 KBtom konda

Issue fork extlink-3281593

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Tom Konda created an issue. See original summary.

tom konda’s picture

tom konda
Primary language Japanese
Location Kanagawa, Japan
commented
Status: Active » Needs review
StatusFileSize
new 3281593-2.patch8.5 KB

Here is a patch for this proposal.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Can this be turned to MR,

May be a good scenario to add test coverage for
Example test module that overrides this setting
Test case verifying that.

smustgrave’s picture

smustgrave commented
Version: 8.x-1.x-dev » 2.0.x-dev
Issue tags: +Needs reroll
smustgrave’s picture

smustgrave commented

Will have to also take into account that jquery and tel: has been added too

smustgrave opened merge request !50

  • smustgrave committed 10f9adf0 on 2.0.x 
    Issue #3281593 by tom konda, smustgrave: Enable to customize an icon...
smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed
Issue tags: -Needs reroll

Re-rolled for jquery removal and to include tel link too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.