Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
These two core tests should be moved to their respective themes, instead of being part of Drupal core tests, so we can deprecate Bartik #3249109: Deprecate Bartik and Seven #3084814: Deprecate Seven theme as mentioned at #3278124: Convert various tests that use bartik/seven to olivero/claro.
3 core/tests/Drupal/FunctionalTests/Theme/SevenLayoutBuilderTest.php
5 core/tests/Drupal/FunctionalTests/Theme/BartikTest.php
Also there are themetests for claro and olivero that use seven and bartik to test uninstallation. These should use a different theme.
./Theme/ClaroTest.php: $this->cssSelect('a[title="Install Seven as default theme"]')[0]->click();
./Theme/OliveroTest.php: $this->cssSelect('a[title="Install Bartik as default theme"]')[0]->click();
Remaining tasks
Update the tests.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
I don't think we need release notes or a change record.
Comment | File | Size | Author |
---|---|---|---|
#6 | 3281457-6.patch | 3.03 KB | quietone |
| |||
#6 | interdiff-3-6.txt | 1.56 KB | quietone |
#3 | 3281457.patch | 1.21 KB | catch |
|
Comments
Comment #2
catchComment #3
catchHopefully all we need to do for this one.
Comment #4
quietone CreditAttribution: quietone at PreviousNext commentedThis does move the two files but ...
I applied the patch and I searched core/tests/Drupal/FunctionalTests for other instances of bartik and seven. There are some in an Installer directory which are being done in #3281444: Update Installer tests to not use Bartik and Seven. Therefor, changing the namespace in the title.
There is also
What about those?
Comment #5
bbralaWell, i was in the same process as you. First dug into the parent issues regarding this to see why only these. Then applied the patch, which looks good and ended up at the same question. There is a few references left, and while looking to see if things are covered in #3278124: Convert various tests that use bartik/seven to olivero/claro it seems the ones in claro and olivero (see #4) are not mentioned in the parent issue.
Comment #6
quietone CreditAttribution: quietone at PreviousNext commentedWhat about using a test theme for testing the uninstall? There was a @todo in ClaroTest to removed the uninstall test. However, I left it in because there is the same test in Olivero.
Comment #7
bbralaI think your approach is good. Bit of scope creep though for this issue, so IS needs updating. I'll do that.
Change is looking good. If tests are green then i'll RTBC.
Comment #8
bbralaAs i post, the tests were done.
Comment #9
catch#6 looks good to me too, good spot on installing Seven in the test.
Comment #11
catchDon't think the ckeditor failures were related.
Comment #13
catchI did an initial version of the patch here, but the changes were just the file moves without any of the substantive changes, so I think I'm still clear to commit this one.
Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!