Problem/Motivation

Discovered in #3272956-15: Hardcode security coverage EOL dates for Drupal 9.4 and 9.5 (as was done for 8.8 and 8.9), but first discovered 2.5 years ealier, in #2991207-120: Drupal core should inform the user of the security coverage for the site's installed minor version including final 8.x LTS releases.

Steps to reproduce

Proposed resolution

Rename XML files
Remove legacy attributes, they are listed on https://www.drupal.org/drupalorg/docs/apis/update-status-xml
Add supported branches

Remaining tasks

Rename XML files
Remove legacy attributes, they are listed on https://www.drupal.org/drupalorg/docs/apis/update-status-xml
Add supported branches
Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3280679

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

Status: Active » Needs review
StatusFileSize
new29.95 KB

I doubt I got everything right … but here's at least a quick patch to indicate the direction, to avoid waiting another 2.5 years to fix this 🤓

wim leers’s picture

AFAICT this is a blocker to being able to do #3115435: Make clear why each XML update.module fixture is created the way it is. First the tests must be in a sane, consistent state, then we'll be able to document it.

Status: Needs review » Needs work

The last submitted patch, 2: 3280679-2.patch, failed testing. View results

dww’s picture

Thanks for running with this! No time right now to review the patch or help the test failures, but I heartily approve of this task. 😉

More later,
-Derek

Version: 10.0.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone made their first commit to this issue’s fork.

quietone’s picture

Issue summary: View changes
Status: Needs work » Needs review

This is converted to an MR, tests updated and the legacy attributes removed. I am not sure what is meant in the title for "add supported branches" So, setting to NR to get some feedback.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

Status: Needs work » Needs review
quietone’s picture

Status: Needs review » Needs work
quietone’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Not sure how to best test this one but the changes appear fine replacing with 8.0 versions

alexpott’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 82d325ee79 to 11.x and 5ed786fdcc to 10.3.x. Thanks!

This was not a clean cherry-pcik to 10.2.x so left on 10.3.x and 11.x. Fingers-crossed we don;t have a security issue in private that makes changes to these tests.

  • alexpott committed 5ed786fd on 10.3.x
    Issue #3280679 by quietone, Wim Leers: Remove legacy attributes, add...

  • alexpott committed 82d325ee on 11.x
    Issue #3280679 by quietone, Wim Leers: Remove legacy attributes, add...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.