Problem/Motivation
Discovered in #3272956-15: Hardcode security coverage EOL dates for Drupal 9.4 and 9.5 (as was done for 8.8 and 8.9), but first discovered 2.5 years ealier, in #2991207-120: Drupal core should inform the user of the security coverage for the site's installed minor version including final 8.x LTS releases.
Steps to reproduce
Proposed resolution
Rename XML files
Remove legacy attributes, they are listed on https://www.drupal.org/drupalorg/docs/apis/update-status-xml
Add supported branches
Remaining tasks
Rename XML files
Remove legacy attributes, they are listed on https://www.drupal.org/drupalorg/docs/apis/update-status-xml
Add supported branches
Review
Commit
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|
Issue fork drupal-3280679
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3280679-remove-legacy-attributes
changes, plain diff MR !7255
Comments
Comment #2
wim leersI doubt I got everything right … but here's at least a quick patch to indicate the direction, to avoid waiting another 2.5 years to fix this 🤓
Comment #3
wim leersAFAICT this is a blocker to being able to do #3115435: Make clear why each XML update.module fixture is created the way it is. First the tests must be in a sane, consistent state, then we'll be able to document it.
Comment #5
dwwThanks for running with this! No time right now to review the patch or help the test failures, but I heartily approve of this task. 😉
More later,
-Derek
Comment #9
quietone commentedThis is converted to an MR, tests updated and the legacy attributes removed. I am not sure what is meant in the title for "add supported branches" So, setting to NR to get some feedback.
Comment #10
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #11
quietone commentedComment #12
quietone commentedComment #13
quietone commentedComment #14
smustgrave commentedNot sure how to best test this one but the changes appear fine replacing with 8.0 versions
Comment #15
alexpottCommitted and pushed 82d325ee79 to 11.x and 5ed786fdcc to 10.3.x. Thanks!
This was not a clean cherry-pcik to 10.2.x so left on 10.3.x and 11.x. Fingers-crossed we don;t have a security issue in private that makes changes to these tests.