JsonApiDocumentTopLevelNormalizerTest::generateProphecies($entity_type_id, $bundle) is called with an extra argument quite a few times. Those need to be removed.
Example:
[$request, $resource_type] = $this->generateProphecies('node', 'article', 'uid');
should be
[$request, $resource_type] = $this->generateProphecies('node', 'article');
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | json-api-3280302-9.patch | 2.41 KB | anoopsingh92 |
| #5 | json-api-3280302-5.patch | 2.4 KB | arunkumark |
| #2 | 3280302-2.patch | 2.41 KB | shashwat purav |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
shashwat purav commentedAdded patch to remove extra argument.
Comment #3
bbralaThe changes look good. I've checked the code if there were any other ones left over, but you seemed to have catched them all, well done :)
Comment #5
arunkumarkPatch has been re-rolled for the latest version of 9.5.x.
Comment #6
hlopez commentedStill looks good, moving back to RTBC
Comment #8
anoopsingh92Comment #9
anoopsingh92Patch has been re-rolled for 9.5.x please review this.
Comment #10
pflora commentedI've reviewed the patch and everything seems to be working fine. I also ran the tests and everything passed! Moving it to RTBC!
Comment #11
alexpottEventually phpstan will catch stuff like this for us. I've checked that this is not in the baseline in 10.x yet so doesn't fail on that env atm.
Committed and pushed f27dc02c28 to 10.1.x and 96ec16f909 to 10.0.x and e6df71a634 to 9.5.x. Thanks!
Will cherry pick to 9.4.x once 9.4.5 is released.
Comment #15
alexpottCommitted d669774 and pushed to 9.4.x. Thanks!
Oops forgot about this one.