Problem/Motivation

Discovered whilst working on #3276839: Remove leftover dumpHeaders property.

In #3230541: Queue items only reserved by cron for 1 second 2 PHPStan errors were fixed by replacing the deprecated constant REQUEST_TIME with the service \Drupal::time()->getRequestTime() (Yay!), but the error suppressions in core/phpstan-baseline.neon where not removed (Booh!).

This leaves us with "Custom Commands Failed" on any test on 10.0.x-dev that changes core/phpstan-baseline.neon, see https://www.drupal.org/pift-ci-job/2379993.

(Tentatively) marking this a major, since we have failing tests in certain circumstances.

Steps to reproduce

Proposed resolution

Create and commit a new core/phpstan-baseline.neon by running $ vendor/bin/phpstan analyze --configuration=core/phpstan.neon.dist --generate-baseline ./core/phpstan-baseline.neon.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3280050

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

mondrake’s picture

Duplicate of #3278782: PHPStan baseline is out of sync which unbelievably is still not committed.

spokje’s picture

Status: Active » Closed (duplicate)

Thanks @mondrake, I _did_ do a search and found nothing related, but I think I need more coffee before I should open issues :)

mondrake’s picture

Well if that were committed one week ago, you wouldn’t. Cannot really understand what’s holding up. We even shipped an alpha with the wrong baseline.

spokje’s picture

I'll just quote @dww here and say:

Core is hard...

Can't win em all (apparently). I'll just get an extra coffee anyway :)