Problem/Motivation

PHPStan baseline is out of sync

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3278782

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes

mondrake opened merge request !2222

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: PHPStan baseline » PHPStan baseline is out of sync
Priority: Normal » Critical
Issue summary: View changes
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
cmlara’s picture

cmlara
he/him
commented
Related issues: +#3230541: Queue items only reserved by cron for 1 second

Linking the issue where we didn't discuss these entries during code change.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Reviewed & tested by the community

oof... i should have caught that in the review. sorry.

Looks good. Only difference I got when generating myself was phpstan shifted around some dblog stuff but it looks like its just fixing alpha ordering and not a functional change.

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented

Looks correct to me. Only removal of phpstan baseline issues, and both removals seems related to linked issue where the files were touched.

Edit: Crosspost with above.

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented
Related issues: +#3259355: Always do a full phpstan analysis on DrupalCI
mondrake’s picture

mondrake
Location 🇮🇹
commented

Re #7, #3278052: Fix added core/phpstan-baseline.neon error suppresion for core/modules/dblog/tests/src/Functional/DbLogResourceTest.php.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e025b90 and pushed to 10.0.x. Thanks!

  • alexpott committed e025b90 on 10.0.x 
    Issue #3278782 by mondrake: PHPStan baseline is out of sync

mondrake closed merge request !2222

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.