Problem/Motivation

When viewing an article, the image displays above the body by default. However, when inputting data, the image field is below the body field.

This obviously does not correspond, but really should for usability reasons.

Steps to reproduce

Login to the site, and add a new article.

Proposed resolution

Move the field above the Body field.

Remaining tasks

Patch
Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 After patch - image field.png352.3 KBdeepalij
#11 Before patch - img field.png334.84 KBdeepalij
manage form display.jpg191.26 KBjasonfelix

Issue fork drupal-3279725

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jasonfelix created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Title: Image field below body field » Default article content type's form display should have image above body (to correspond with visual output)
Issue summary: View changes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Priority: Normal » Minor
Issue tags: +Bug Smash Initiative, +Novice
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Postponed (maintainer needs more info)

Can we do some git forensics to work out if this was done by design

When you create content you typically add the image one and then retain it, but you come back to edit the body several times. I wonder if that was the reasoning here

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

I brought this to the Drupal UX meeting at #3279239: Drupal Usability Meeting 2022-05-13. There was unanimous consensus that moving the image form element above the body field is better usability. See the issue and the posted recording more more detailed information.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Active

Setting back to active based on response in #5

rpayanm made their first commit to this issue’s fork.

rpayanm opened merge request !2981

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Active » Needs review
deepalij’s picture

deepalij commented
StatusFileSize
new Before patch - img field.png334.84 KB
new After patch - image field.png352.3 KB

Verified and tested patch merge request !2981 from #9 on 10.1.x-dev version.
Patch applied successfully.

The default article content type's form display now has an image field above the body field

Before patch:
before

After patch:
after

RTBC +1

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the MR and the testing. Marking RTBC based on:

  1. Passes automated tests
  2. Passes manual testing
  3. Code (config) change is simple
  4. Both standard and demo_umami profiles have been updated
  5. Issue summary is clear
  6. UX team has approved the change
  7. Change only addresses what's in the issue summary
  8. Although this is marked a bug, I don't think automated tests would be added for this (move back to needs work if my assumption is not correct)
quietone’s picture

quietone commented

This looks fine to me and I checked with larowlan to be sure that I wasn't missing anything.

So, I will commit in the next 24 hours.

quietone’s picture

quietone commented
Title: Default article content type's form display should have image above body (to correspond with visual output) » Default article content type form display should have image above body to match display

Tweak the title

quietone’s picture

quietone commented

Someone else will have to commit this. Once again, key signing fails. Although it worked last week and the keys are still valid.

error: gpg failed to sign the data
fatal: failed to write commit object

  • larowlan committed 8a53a6d on 10.1.x 
    Issue #3279725 by rpayanm, DeepaliJ, jasonfelix, quietone, mherchel,...
  • larowlan committed 5527427 on 9.5.x
    Issue #3279725 by rpayanm, DeepaliJ, jasonfelix, quietone, mherchel,...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 10.1.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

I don't think this warrants tests, we're just changing default config.

Committed to 10.1.x and cherry-picked to 10.0.x and 9.5.x

Not cherry-picking to 9.4.x because this is default config and that branch is ~1 week away from security only support.

  • larowlan committed 5c800d6 on 10.0.x 
    Issue #3279725 by rpayanm, DeepaliJ, jasonfelix, quietone, mherchel,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.