Problem/Motivation
To improve the accessibility of the modal close buttons it would be better if they were buttons with appropriate aria labels etc.
Currently, the close button looks like this:
<span class="class-modal-close spb_close">×</span>
Steps to reproduce
- Install and configure the modal
- Use the configured setup to visit the page where the modal should display
- Open the modal
- Inspect the code
Proposed resolution
Should be something like:
<button type='button' aria-label='close' class="class-modal-close spb_close">×</button>
This should work better for users who rely on the content being read out by a screen reader as the html will be more semantically correct.
Remaining tasks
Investigate the modal open and minimise buttons also.
User interface changes
Should display no differently for sighted users using a mouse.
API changes
None
Data model changes
Dom elements will change slightly.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Screenshot 2022-08-12 at 14.03.02.png | 334.71 KB | alina.basarabeanu |
Issue fork simple_popup_blocks-3279461
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
the_g_bomb commentedComment #4
the_g_bomb commentedComment #5
alina.basarabeanu commentedThe patch is working with drupal/simple_popup_blocks (8.x-2.8) and drupal/core (9.4.2)
Comment #6
i-trokhanenkoThe MR5 - https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/... works fine for me. Making RTBC. Thanks!
Comment #7
i-trokhanenkoComment #8
the_g_bomb commentedThanks for updating the target branch
Comment #10
i-trokhanenkoCommitted. Thanks for the contribution Gareth and Alina!