Change the method Drupal\Core\DrupalKernel::handle() to make it work for the Swoole module

The rationale makes sense.
Code-wise, the patch trivially does what it announces.
It contains a test that is green.
No BC breaking API change, so no change record needed.

1) Technically a red test-only patch is needed. So NW for that.

I don't see a reason this can not go to 9.x (but may overlook sth) so changing to 9.5.x.

THX for the terrific work daffie!

All from #3 resolved, red test plus CR, so RTBC.

@daffie: The UI says it "re-tests (only the red patch) every 2 days". Maybe uploading first green then red patch might prevent that bumping back and forth.

Given that \Drupal\Core\DrupalKernel::bootEnvironment() has protection and so does ::boot() in terms of calling again wouldn't it be better to change ::handle?

If we change the try{} block to

    try {
      if (!$this->booted) {
        $this->initializeSettings($request);

        // Redirect the user to the installation script if Drupal has not been
        // installed yet (i.e., if no $databases array has been defined in the
        // settings.php file) and we are not already installing.
        if (!Database::getConnectionInfo() && !InstallerKernel::installationAttempted() && PHP_SAPI !== 'cli') {
          $catch = TRUE;
          throw new DatabaseNotFoundException();
        }
        $this->boot();
      }
      $response = $this->getHttpKernel()->handle($request, $type, $catch);
    }

I think this will mean the Swoole doesn't have to know so much about the internals of getting a response whilst making it easier for ::handle() to be re-entrant without doing unnecessary work.

Yay, that looks cleaner!

Btw not sure check for CLI is handy, Octane has roadrunner's implementation as well + reactphp with fibers also will be blocked as it running via CLI

I think we can do even better here tbh...

I we change \Drupal\Core\Installer\InstallerRedirectTrait::shouldRedirectToInstaller to do:

    // If the database wasn't found, assume the user hasn't entered it properly
    // and redirect to the installer. This check needs to come first because a
    // DatabaseNotFoundException is also an instance of DatabaseException.
    if ($exception instanceof DatabaseNotFoundException || $exception instanceof ConnectionNotDefinedException) {
      return TRUE;
    }

Note we'll need to add ConnectionNotDefinedException to the use statements. Then \Drupal\Core\DrupalKernel::handle() can be...

  public function handle(Request $request, $type = self::MASTER_REQUEST, $catch = TRUE): Response {
    // Ensure sane PHP environment variables.
    static::bootEnvironment();

    try {
      if (!$this->booted) {
        $this->initializeSettings($request);
        $this->boot();
      }
      $response = $this->getHttpKernel()->handle($request, $type, $catch);
    }
    catch (\Exception $e) {
      if ($catch === FALSE) {
        throw $e;
      }

      $response = $this->handleException($e, $request, $type);
    }

    // Adapt response headers to the current request.
    $response->prepare($request);

    return $response;
  }

It's tempting to move the

    // Ensure sane PHP environment variables.
    static::bootEnvironment();

inside the if (!$this->booted) { too. Not sure about that... maybe a follow-up.

I hope it could help to solve related #2613044: Requests are pushed onto the request stack twice, popped once

Made changes as per comment #17, please review.

Code-wise i can confirm that #17 review is done in #19 / #21 (+cs-fix).

Dunno why the php7 tests fail:

Re PHP 7.3: I see the same 43 errors in PhpRequirementsTest locally without this patch, on bare Drupal 9.5.x, so it's not related. Not sure if there's an open issue for that though.

Update: There is an open issue for that - #3261447-55: Add an API for dynamically setting recommended and supported PHP versions based on known and predicted PHP release schedules.

Re PHP 7.4 & PgSQL 9.5:

The database server version 9.5.19 is less than the minimum required version 10.

So I requeued PHP 7.3 & 8.1 with PgSQL 10 - there's no option for PHP 7.4 with PgSQL 10 for some reason.

Tests passed.

Committed and pushed 61e4c24929 to 10.0.x and dcca2f9041 to 9.5.x. Thanks!