In #3087701: Enable Claro as the admin theme in Umami we enabled Claro as the new admin theme for Umami. In there we added the Theming Blocks config to the core/profiles/demo_umami/config/install directory.
In #3278565: Remove Claro block configuration from Standard we removed those blocks from the Standard profile, because those blocks config are already present in the core/themes/claro/config/optional directory.
Since Claro already ships with its block configuration, we should be able to remove the block configuration from Umami.
In Drupal 9.4.0-alpha1, the Umami Demo profile was updated to use Claro as its default theme, and theme blocks for Claro were added to the profile's optional default configuration. However, these blocks were exact copies of the blocks installed by Claro by default, so the default config was not necessary. In Drupal 9.4.0-beta1, the optional configuration in the profile has been removed in favor of the blocks provided by the theme.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3278732-2.patch | 5.07 KB | spokje |
Comments
Comment #2
spokjeComment #3
lauriii+1'd this already on Slack.
Checked there aren't any Claro block configuration remaining in Umami and all looks good.
Comment #4
catchCommitted/pushed to 10.0.x, cherry-picked to 9.5.x and 9.4.x, thanks!
Comment #6
spokjeComment #7
xjmComment #8
wim leersComment #9
wim leersDoes this really need a release note? Umami only offers a demo, no backwards compatibility or upgrade path is provided? 🤔
The big news is that Umami now uses Claro as the admin theme, this feels like an implementation detail that the general audience would not be affected by or care about?
Comment #10
xjm@Wim Leers I think it only might need an incremental release note for the change between alpha1 and beta1 in the data model; for 9.4.0 there will already be an overall release note about the profiles being changed to use Claro.
Comment #11
xjmAdded a rough draft of what the release note might be for this (I think).
Comment #13
xjmWe decided to exclude it as per @Wim Leers' suggestion, so retroactively untagging.