Problem/Motivation

#3277057: Make Claro the default admin theme in Standard profile added block configuration for Claro to Standard install profile. However, Claro already ships with block configuration in the theme itself.

Proposed resolution

Since Claro already ships with its block configuration, we should be able to remove the block configuration from Standard.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3278565-2.patch5.02 KBlauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 3278565-2.patch5.02 KB
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Related issues: +#3278215: (Not so) Random test failures SettingsTrayIntegrationTest

Status: Needs review » Needs work

The last submitted patch, 2: 3278565-2.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Claro doesn't ship with the config anymore it needs to be moved back in 9.4.x/9.5.x/10.0.x as far as I know,

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

I think the block config is still there: https://git.drupalcode.org/project/drupal/-/tree/9.4.x/core/themes/claro... , https://git.drupalcode.org/project/drupal/-/tree/9.5.x/core/themes/claro... and https://git.drupalcode.org/project/drupal/-/tree/10.0.x/core/themes/clar...

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Agreeing with @lauriii here, block config for Claro is still present in 9.4.x-dev, 9.5.x-dev and 10.0.x-dev as shown by the links in #6.

I _think_ @alexpott is thinking about the Olivero block config here, which is(n't)/was(n't)/could be present in [insert-random-branch]. (Yes, lost track myself).

This one however is RTBC for me.

  • catch committed 2d9e5ea on 10.0.x 
    Issue #3278565 by lauriii, Spokje: Remove Claro block configuration from...
  • catch committed 1a5f6df on 9.4.x
    Issue #3278565 by lauriii, Spokje: Remove Claro block configuration from...
  • catch committed 4b54cc5 on 9.5.x
    Issue #3278565 by lauriii, Spokje: Remove Claro block configuration from...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x, cherry-picked to 9.5.x and 9.4.x.

#3278674: Decide how blocks should be shipped for Claro and Olivero is open for deciding exactly what we want to do long term here, but getting to a consistent and working (and potentially final if we decide it's what we want after all) is great.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.