Problem/Motivation

When Viewing /admin/structure/block/ with Toolbar Manage Menu (vertical layout) The Link and text for "Exit Block Region Demonstration" is hidden by the overlaying menu.

Steps to reproduce

View Block Region Demonstration on /admin/structure/block/ change to vertical layout on Toolbar Manage Menu.

Not yet duplicated in later versions.

Proposed resolution

Position change for link

Remaining tasks

User interface changes

API changes

None

Data model changes

None

Release notes snippet

Issue fork drupal-3278310

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bsnodgrass created an issue. See original summary.

bsnodgrass’s picture

Title: Toolbar Manage Vertical Menu Hides Link to "Exit Demonstrate Block Regions" on Claro Theme » Toolbar Manage Vertical Menu Hides Link to "Exit Block Region Demonstration" on Claro Theme

Title change

bsnodgrass’s picture

Confirmed same issue in 9.4.0-dev

Not sure what version should be reported on the Issue Summary. Latest version confirmed?

Saurabh Srivastava’s picture

Status: Active » Needs review
StatusFileSize
new356.35 KB
new238.95 KB
new246.92 KB
new254.66 KB

Here Unable to find the Error on Drupal versions 9.3 and 9.4 with two different browsers Chrome and firefox. for references, I am Attaching the Screenshot.

bsnodgrass’s picture

Version: 9.3.x-dev » 9.4.x-dev
Status: Needs review » Active

Thanks for adding the screenshots. Changing status back to active, since there is no fix.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

rkoller’s picture

Version: 9.5.x-dev » 10.1.x-dev
Component: Claro theme » Olivero theme
StatusFileSize
new147.11 KB

The issue still applies to 10.1.x (tested on Safari, Firefox and Edge on MacOS). I've attached a brief video to illustrate the issue switching between the horizontal and vertical toolbar. But i think the component should be set to olivero and not claro since the region preview is shown in the default theme? and in regards of olivero it looks like when the admin toolbar is set to the vertical orientation the position: fixed on the exit block region demonstration link is the reason why it stays hidden behind the toolbar?

rkoller’s picture

...or maybe i was a little bit premature. i've switched the default theme to claro afterwards. the issue applies there as well. different layout but the problem in general is the same. so would the component in concern be the block module instead where function block_page_top is located which contains the backlink that is hidden by the vertical admin toolbar? and it looks like the position: fixed could be found in line 21 in block.admin.css. so would it be the correct step to switch the component to the block module?

Gauravvvv made their first commit to this issue’s fork.

gauravvvv’s picture

Status: Active » Needs review
rkoller’s picture

Component: Olivero theme » block.module
Status: Needs review » Needs work
StatusFileSize
new217.43 KB
new268.73 KB

Thanks @gauravvvv for working on a fix! I've applied the patch and tested the following details:

- first with the admin_toolbar module installed i've tested in olivero. the exit block is shown. the only detail is that when the admin_toolbar is set to the vertical toolbar there is a horizontal scrollbar. but that happens without the patch applied in olivero as well.
olivero block region demonstration theme
- with claro as default theme that scrolling doesnt happen and the exit block is displayed in the same way like with olivero.
claro block region demonstration theme
- same for the bootstrap barrio 5 theme. there only the skip to main content link is also shown. but that is an issue with the barrio theme. but the functionality of the exit block region demonstration link is reachable.
- the results are the same with the admin_toolbar module uninstalled for each of the aforementioned themes set as the default theme.

the fix works and is straight forward. nice! the only detail i wonder if it would make sense (or if it is even necessary) to add a test to check if the link is visible and not covered and hidden by any other element? i am just not sure if you use isVisible in nightwatch if that is checking if the element is visible and not something like display: none is applied or if isVisible actually tests if an element is in the visible viewport and not covered nor hidden? i'll set the status to needs work. in case a test isn't necessary here i would consider the issue RTBC and the status could be changed to that.

and since the patch changes code within the block module only, i'll change the component to the block module also.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dsandhya’s picture

Please review the patch.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.