Problem/Motivation

From #3275864: Update to Symfony 6.1.1

New deprecation in BETA2 release of Symfony 6.1:

  4x: Since symfony/routing 6.1: The "Symfony\Component\Routing\Matcher\UrlMatcher::handleRouteRequirements()" method will have a new "array $routeParameters" argument in version 7.0, not defining it is deprecated.
    4x in UrlTest::testLinkBubbleableMetadata from Drupal\Tests\system\Kernel\Common

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3278122

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3276187: Since symfony/routing 6.1: Construction of "Symfony\Component\Routing\Exception\MissingMandatoryParametersException" with an exception message is deprecated, provide the route name and an array of missing parameters instead.

I think/hope we can do the same as in #3276187: Since symfony/routing 6.1: Construction of "Symfony\Component\Routing\Exception\MissingMandatoryParametersException" with an exception message is deprecated, provide the route name and an array of missing parameters instead., with the same reasoning as in #3276187-5: Since symfony/routing 6.1: Construction of "Symfony\Component\Routing\Exception\MissingMandatoryParametersException" with an exception message is deprecated, provide the route name and an array of missing parameters instead.: Silence this deprecation and solve it when SF6.1 is required by D10.0

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Parent issue: » #3275864: Update to Symfony 6.1.1
spokje’s picture

spokje
Primary language Dutch
commented

Looks like Symfony\Component\Routing\Matcher\UrlMatcher::handleRouteRequirements() is only used in \Drupal\Core\Routing\Router::doMatchCollection() here.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Postponed

#3 makes sense IMHO, let's add the deprecation silencer in the parent

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +Symfony 7
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Postponed » Active

Parent issue was resolved, this can be worked on now.

mondrake opened merge request !2395

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs work

andregp made their first commit to this issue’s fork.

andregp’s picture

andregp commented
Status: Needs work » Needs review

I hope it solves the issue :)

daffie’s picture

daffie commented
Status: Needs review » Needs work

See the thread on the MR.

andregp’s picture

andregp commented

Thanks for the review @daffie, I just fixed it :)

andregp’s picture

andregp commented
Status: Needs work » Needs review

Sorry I had a bit trouble merging here :P

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work
andregp’s picture

andregp commented
Status: Needs work » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Thank you - the MR still has a small glitch, see inline, but can be fixed on commit.

  • catch committed 256ceca on 10.1.x 
    Issue #3278122 by andregp, mondrake, Spokje, daffie: Since symfony/...

  • catch committed b0a87e4 on 10.0.x 
    Issue #3278122 by andregp, mondrake, Spokje, daffie: Since symfony/...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

mondrake closed merge request !2395

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.