From #3275864: Update to Symfony 6.1.1.
2x: Since symfony/routing 6.1: Construction of "Symfony\Component\Routing\Exception\MissingMandatoryParametersException" with an exception message is deprecated, provide the route name and an array of missing parameters instead.
2x in HelpTopicTest::testHelpLinks from Drupal\Tests\help_topics\Functional
1x: Since symfony/routing 6.1: Construction of "Symfony\Component\Routing\Exception\MissingMandatoryParametersException" with an exception message is deprecated, provide the route name and an array of missing parameters instead.
1x in EntityUrlTest::testUriRelationships from Drupal\Tests\Core\Entity
https://www.drupal.org/pift-ci-job/2364329
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !2138
Comments
Comment #2
catchComment #3
catchComment #4
mondrakeOn this
Comment #5
mondrakeNo patch yet, we need to agree first. Since there's no Drupal release with Symfony 6.0 yet, and this behaviour is introduced in Symfony 6.1, IMHO the best solution is just to silence this deprecation now, then update Symfony to 6.1, then work directly on the changes with 6.1 without having to care for 6.0 BC.
Thoughts?
Comment #6
catch@mondrake that makes sense to me, we only throw the exception from one place in core (UrlGenerator) + a test, so easy to make the change once we're actually on 6.1
Comment #7
mondrakeOk so let's do the deprecation in the parent then.
Comment #8
mondrakeComment #10
mondrakeComment #11
mondrakeParent issue was resolved, this can be worked on now.
Comment #12
mondrakeComment #13
mondrakeComment #14
daffie commentedThe deprecation suppression has been removed and the testbot does not return a deprecation.
The 2 fixes look good to me.
For me it is RTBC.
Comment #15
alexpottCommitted 847ab04 and pushed to 10.0.x. Thanks!