Problem/Motivation

Variable replacement occurs in SubjectEmailAdjuster::build().

  • It's too soon - we haven't yet switched theme/language etc.
  • It doesn't give any chance for hooks to alter the subject before token replacement
  • If a hook need to replace variables in a subject, the code isn't reusable

Proposed resolution

  1. Move replacement into Email::render()
  2. Add an optional argument to EmailInterface::subject() to enable replacement

Remaining tasks

User interface changes

API changes

Data model changes

Comments

AdamPS created an issue. See original summary.

adamps’s picture

Status: Active » Needs review
StatusFileSize
new4.85 KB

  • AdamPS committed 358aff5 on 1.x
    Issue #3278054 by AdamPS: Fix replacement of variables in subject
    
adamps’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.