Problem/Motivation

file_create_url() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use the appropriate method on \Drupal\Core\File\FileUrlGeneratorInterface instead. See https://www.drupal.org/node/2940031

drupal_get_path() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use \Drupal\Core\Extension\ExtensionPathResolver::getPath() instead. See https://www.drupal.org/node/2940438

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 interdiff_6-8.txt766 bytesheddn
#8 3277790-8.patch17.8 KBheddn
#6 3277790-6.patch18.74 KBheddn
#4 3277790-4.patch19.07 KBheddn
#4 interdiff_3-4.txt2.57 KBheddn
#3 3277790-3.patch18.22 KBheddn
#3 interdiff_2-3.txt556 bytesheddn
#2 3277790.patch18.09 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review
StatusFileSize
new 3277790.patch18.09 KB
heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new interdiff_2-3.txt556 bytes
new 3277790-3.patch18.22 KB
heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new interdiff_3-4.txt2.57 KB
new 3277790-4.patch19.07 KB

Missed a place.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@heddn,

I'm getting this, maybe you have a combo with another patch?

patching file advagg_css_minify/src/Asset/CssMinifier.php
Hunk #1 succeeded at 5 with fuzz 2.
Hunk #2 succeeded at 15 (offset 1 line).
Hunk #3 FAILED at 122.
1 out of 3 hunks FAILED -- saving rejects to file advagg_css_minify/src/Asset/CssMinifier.php.rej
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Version: 8.x-4.x-dev » 5.0.0
StatusFileSize
new 3277790-6.patch18.74 KB
rossb89’s picture

rossb89 commented
Status: Needs review » Reviewed & tested by the community

Thanks Heddn. The code here looks sensible enough to my eyes.

I haven't had any unexpected issues since applying the patch and no php errors / warnings etc in the logs... I think this is good to go?

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new 3277790-8.patch17.8 KB
new interdiff_6-8.txt766 bytes

Keeping RTBC, but removing the .info.yml changes as they conflict w/ #3303968: Automated Drupal 10 compatibility fixes.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Version: 5.0.0 » 6.0.x-dev

Since this would remove support for core prior to Drupal 9.3.0, switching this (and all other D10 stuff) to a new major version - 6.0.x.
Thanks for the patch and all the work here Heddn.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.