Support Drupal 10 and update all use of deprecation in the Google Analytics Reports module [#3277448]

Problem/Motivation

Drupal 10.0 development

Thank you so much for the Drupal Core team

Following with

Drupal 10.0.0 is coming soon. Help us test it today!

Drupal core 10.0.0-alpha5

Released 9 Jun 2022

A snapshot to allow module and theme developers to test compatibility with the next major release. No upgrade path is provided between alpha releases and many additional changes will be included prior to 10.0.0.

Proposed resolution

Support Drupal ~10 and change all deprecated packages, classes, functions, asset libraries to the Drupal 10 way
Real physical testing with Drupal ~10
Automated upgrade to Drupal ~10

Remaining tasks

✅ File an issue
✅ Addition/Change/Update/Fix
✅ Testing to ensure no regression
➖ Automated unit testing coverage
➖ Automated functional testing coverage
➖ UX/UI designer responsibilities
➖ Readability
➖ Accessibility
➖ Performance
➖ Security
➖ Documentation
✅ Code review by maintainers
✅ Full testing and approval
✅ Credit contributors
✅ Review with the product owner
✅ Release notes snippet
✅ Release google_analytics_reports-8.x-3.0, google_analytics_reports-4.0.0-alpha2

API changes

Data model changes

Release notes snippet

Issue #3277448: Support Drupal 10 and update all use of deprecation in the Google Analytics Reports module

Comment	File	Size	Author
#21	Real physical testing round for Google Analytics Reports.zip	4.76 KB	rajab natshah

Issue fork google_analytics_reports-3277448

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3277448-support-drupal-10 changes, plain diff MR !8
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

27 April 2022 at 15:02

Rajab Natshah created an issue. See original summary.

Comment #2

5 May 2022 at 10:33

Rajab Natshah committed a11c7b4 on 8.x-3.x

Issue #3277448: Support Drupal 10 and update all use of deprecations in...

Comment #3

5 May 2022 at 10:34

Rajab Natshah committed 9d22c2f on 4.0.x

Issue #3277448: Support Drupal 10 and update all use of deprecations in...

Comment #4

rajab natshah

he/him

commented 5 May 2022 at 10:35

Title:

Support Drupal 10 and update all use of deprecations in the Google Analytics Reports module

» Issue #3277448: Support Drupal 10 and update all use of deprecations in the Google Analytics Reports module

Comment #5

rajab natshah

he/him

commented 5 May 2022 at 10:39

Title:	Issue #3277448: Support Drupal 10 and update all use of deprecations in the Google Analytics Reports module	» Support Drupal 10 and update all use of deprecations in the Google Analytics Reports module
Issue summary:	View changes

Comment #6

rajab natshah

he/him

commented 5 May 2022 at 10:39

Status:

Active

» Needs review

Comment #7

rajab natshah

he/him

commented 8 May 2022 at 16:31

Issue summary:

View changes

Comment #8

rajab natshah

he/him

commented 11 May 2022 at 09:03

Title:

Support Drupal 10 and update all use of deprecations in the Google Analytics Reports module

» Support Drupal 10 and update all use of deprecation in the Google Analytics Reports module

Comment #9

11 May 2022 at 13:10

marcusvsouza made their first commit to this issue’s fork.

Comment #10

rajab natshah

he/him

commented 16 May 2022 at 03:43

Issue tags:

+Drupal 10 compatibility

Comment #11

rajab natshah

he/him

commented 9 June 2022 at 08:10

Issue summary:

View changes

Comment #12

20 December 2022 at 14:23

VladimirAus made their first commit to this issue’s fork.

Comment #13

vladimiraus

English

Brisbane 🇦🇺

commented 20 December 2022 at 14:23

Version:	8.x-3.x-dev	» 4.0.x-dev
Assigned:	rajab natshah	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

Comment #14

20 December 2022 at 14:23

VladimirAus opened merge request !8

Comment #15

23 January 2023 at 07:38

Rajab Natshah committed f355b75b on 4.0.x authored by VladimirAus

Issue #3277448: Support Drupal 10 and update all use of deprecation in...

Comment #16

23 January 2023 at 08:02

Rajab Natshah committed 901a86ab on 4.0.x

Issue #3277448: Support Drupal 10 and update all use of deprecation in...

Comment #17

23 January 2023 at 08:05

Rajab Natshah committed 7a22f7ba on 8.x-3.x

Issue #3277448: Support Drupal 10 and update all use of deprecation in...

Comment #18

23 January 2023 at 11:08

Rajab Natshah committed aeccc494 on 8.x-3.x

Issue #3277448: Support Drupal 10 and update all use of deprecation in...

Comment #19

rajab natshah

he/him

commented 23 January 2023 at 11:10


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Google Analytics Reports 8.x-3.0-rc3
Scanned on Tue, 01/17/2023 - 22:41.

2 errors found. 2 warnings found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.

Drupal 10 compatibility

modules/contrib/google_analytics_reports/google_analytics_reports.install:
┌─────────┬──────┬────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                        MESSAGE                         │
├─────────┼──────┼────────────────────────────────────────────────────────┤
│ Fix now │ 85   │ Call to deprecated function drupal_uninstall_schema(). │
│         │      │ Deprecated in drupal:9.2.0 and is removed from         │
│         │      │ drupal:10.0.0. No direct replacement is provided.      │
│         │      │                                                        │
└─────────┴──────┴────────────────────────────────────────────────────────┘

modules/contrib/google_analytics_reports/google_analytics_reports_api/src/Form/G
oogleAnalyticsReportsApiAdminSettingsForm.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                         MESSAGE                         │
├──────────┼──────┼─────────────────────────────────────────────────────────┤
│ Fix with │ 116  │ Call to deprecated function render(). Deprecated in     │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use     │
│          │      │ Drupal\Core\Render\RendererInterface::render() instead. │
│          │      │                                                         │
└──────────┴──────┴─────────────────────────────────────────────────────────┘

modules/contrib/google_analytics_reports/google_analytics_reports.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
│ manually │      │ compatible with the next major version of Drupal core. See │
│          │      │ https://drupal.org/node/3070687.                           │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

modules/contrib/google_analytics_reports/google_analytics_reports_api/google_ana
lytics_reports_api.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
│ manually │      │ compatible with the next major version of Drupal core. See │
│          │      │ https://drupal.org/node/3070687.                           │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

Comment #20

23 January 2023 at 11:22

Rajab Natshah committed c91ed6c8 on 4.0.x

Issue #3277448: Support Drupal 10 and update all use of deprecation in...

Comment #21

rajab natshah

he/him

commented 23 January 2023 at 12:34

Status	File	Size
new	Real physical testing round for Google Analytics Reports.zip	4.76 KB

Had Real physical testing round for Google Analytics Reports

Attached the Bash files for the full testing round

3.x-dev with Drupal ~9.0
3.x-dev with Drupal ~10.0

4.x-dev with Drupal ~9.0
4.x-dev with Drupal ~10

Comment #22

rajab natshah

he/him

commented 23 January 2023 at 12:35

Status:

Reviewed & tested by the community

» Fixed

Comment #23

rajab natshah

he/him

commented 23 January 2023 at 12:38

Assigned:	Unassigned	» mohammed j. razem
Issue summary:	View changes
Status:	Fixed	» Needs review

Comment #24

rajab natshah

he/him

commented 23 January 2023 at 12:41

Assigned:	mohammed j. razem	» Unassigned
Issue summary:	View changes
Status:	Needs review	» Fixed
Issue tags:		+google_analytics_reports-8.x-3.0, +google_analytics_reports-4.0.0-alpha2