advagg_js_compress() cron stuck issue

Hi @asghar, I think we should keep backward compatibility here. So, I would rather use explicit casting to solve an issue

Hi!
For backward compatibility with PHP 7, i would like to change patch, according to https://www.php.net/manual/en/function.substr.php
For PHP 8 - "The function returns an empty string where it previously returned false."

Any reason we shouldn't take the approach used for D9 version and do a wholesale replacement of jshrink.inc? https://www.drupal.org/project/advagg/issues/3252394

The patch in #6 works for us and applies cleanly to latest stable.

Drupal 7.92
Advagg 7.x-2.35
PHP 8.0.21

I tried the replacement of the whole jshrink.inc file from the D9 fix, and it also seems to work.

The solution there is the avoidance of substr()

+      // Otherwise we start pulling from the input.
+      $char = $this->index < $this->len ? $this->input[$this->index] : false;
+
+      // If the next character doesn't exist return false.
+      if (isset($char) && $char === false) {
+        return false;
+      }

+1 for #6. Just maybe isset($char) can be removed, because $char is always defined there.

Not sure we can use latest jshrink version while D7 minimum requirements is PHP 5.3, but for latest jshrink PHP 5.6.

About #9 - it seems that $this->len is undefined. The fragment can't be used without other code replacement.

Same problem with Drup 9.4.8 and php 8.0.26
It works with the #2 patch.

Thank you.

Drupal 7.94
PHP 8.0.21 or PHP 7.4.33
Advagg 7.x-2.35

After applying the patch, the Status report /admin/reports/status and Site configuration /admin/config stop responding. No problems seen on other pages.
If you cancel the patch everything works fine

I agree with @darkodev in #8 we should use #3252394-31: JShrink incompatible with PHP 8 I have a comment in #31 with a better solution than backporting the hardcoded class changes

#6 is working for me, setting this to RTBC as a simple solution.

Re-roll against latest released version (#6 does not apply) 7.x-2.35

@joelpittet, can you send us a patch with jShrink new version?

Thanks for working on this!

Unless we want to intentionally drop support for PHP < 5.6, I think I would prefer the simple fix in #6 (see the comment #10). I am also not sure if someone will be able to provide the more complicated patch as suggested by #8 in this D7 phase.

In my case, it leads to server lagging and interaction of site works. I've increased priority to higher.

The patch from #16 fixed the problem.

#16 worked for me!

#16 works for my sites as well.

Since this issue priority is Major, marking RTBC unless @poker10 or other maintainers have something to say about it.

The commit in #16 can go in now, and then someone can work on the backport for jShrink at a later date if it's still important.

Even though there is a workaround mentioned in #3252394-31: JShrink incompatible with PHP 8, I think that it is worth fixing this as it is a small fix.

For others needing a newer jShrink, please check the approach mentioned in the comment #31 on the link above.

Committed and pushed this to 7.x-2.x, thanks!