When trying to add a 'To' address in a mailer policy, I got some errors and notification based on the fact, the $addresses variable is NULL, on the moment you try to add the first address.

CommentFileSizeAuthor
#8 symfony_mailer.no-addresses.3276948-interdiff-7-8.txt914 bytesadamps
#8 symfony_mailer.no-addresses.3276948-8.patch1.81 KBadamps
#7 symfony_mailer.no-addresses.3276948-7.patch1.54 KBadamps
#6 Screenshot 2022-04-27 163805.png15.12 KBkensae
#6 Screenshot 2022-04-27 163643.png5.81 KBkensae
#6 Screenshot 2022-04-27 163542.png12.73 KBkensae

Issue fork symfony_mailer-3276948

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kensae created an issue. See original summary.

kensae’s picture

kensae commented
Title: Multiple errors in AddressAdjusterBase » Multiple errors in AddressAdjusterBase when no addresses set yet

kensae opened merge request !21

kensae’s picture

kensae commented
Status: Active » Needs review
adamps’s picture

adamps commented

Please can you explain exactly how to hit the bug and the errors that you see?

I can add a To address without any problems. I see a single error if I save without including any addresses - is that what you mean?

Warning: Invalid argument supplied for foreach() in Drupal\symfony_mailer\Plugin\EmailAdjuster\AddressAdjusterBase->settingsForm() (line 60 of modules/contrib/symfony_mailer/src/Plugin/EmailAdjuster/AddressAdjusterBase.php).

kensae’s picture

kensae commented
StatusFileSize
new Screenshot 2022-04-27 163542.png12.73 KB
new Screenshot 2022-04-27 163643.png5.81 KB
new Screenshot 2022-04-27 163805.png15.12 KB

I'm trying to add a To address in the policy User » Admin (user awaiting approval) (admin/config/system/mailer/policy/user.register_pending_approval_admin).

- I select the 'To' option and click 'Add Element'

Add To Element

- Then on the 'To' element section I click 'Add Address'

Add Address

- The form to add the address doesn't appear and I've got the folowing error on the ajax callback: TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in array_filter() (line 152 of /modules/contrib/symfony_mailer/src/Plugin/EmailAdjuster/AddressAdjusterBase.php).

Error on ajax callback

After add adding the patch from my merge request the issue has been resolved: https://git.drupalcode.org/project/symfony_mailer/-/merge_requests/21.patch

adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.no-addresses.3276948-7.patch1.54 KB

Thanks for explaining.

Here is an updated patch - please can you take a look?

  • Use the ?? operator to simplify the code
  • Create an empty address if none is present yet
  • Error message if the form is submitted without an address
adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.no-addresses.3276948-8.patch1.81 KB
new symfony_mailer.no-addresses.3276948-interdiff-7-8.txt914 bytes

Fix some glitches

  • AdamPS committed c1cb979 on 1.x 
    Issue #3276948 by kensae, AdamPS: Multiple errors in AddressAdjusterBase...
adamps’s picture

adamps commented
Status: Needs review » Fixed

OK I'll commit this so I don't have too many patches hanging around on my dev box. Please let me know if it works for you - we can always do another commit if needed.

kensae’s picture

kensae commented

Patch in #8 works for me. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

AdamPS closed merge request !21