Proposed resolution

  • For consistency, rename the feature file, [Verb][Resources].feature after the prefix.

Issue fork cloud-3276714

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kumikoono created an issue. See original summary.

kumikoono opened merge request !879

kumikoono’s picture

kumikoono commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Refactor BDD test feature files for k8s module » Refactor BDD test feature files (K8s)
Status: Needs review » Reviewed & tested by the community

@kumikoono

Thank you for the refactoring. It looks good. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

@kumikoono

I'm trying to merge the patch; but it failed. Can you rebase the patch? Thanks!

kumikoono’s picture

kumikoono commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@kumikoono

Thank you for the update. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@kumikoono

Could you please rebase the patch? Thanks!

kumikoono’s picture

kumikoono commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@kumikoono

Thank you for the update. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 1048817 on 5.x authored by kumikoono 
    Issue #3276714 by kumikoono, yas: Refactor BDD test feature files (K8s)

  • yas committed d025e95 on 4.x authored by kumikoono 
    Issue #3276714 by kumikoono, yas: Refactor BDD test feature files (K8s)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.