Problem/Motivation

Local video not working on iOS, I checked the issue and found that there are some policies for iOS that required a user gesture to play media in a or element.

Steps to reproduce

  1. Add local video content to Varbase Media Header Slider.
  2. Add the heroslider block to a page in the theme region or the homepage using the layout builder.
  3. Open the page on the safari browser on iPhone.
  4. You will notice that the video will not play in the background.

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 9.0.9, varbase_heroslider_media-9.0.6

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3275939 by Odai Atieh: Fixed not working local video on iOS with playsinline & muted options

Issue fork varbase_heroslider_media-3275939

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Odai Atieh created an issue. See original summary.

Odai Atieh opened merge request !8

odai atieh’s picture

odai atieh
he/him
Primary language English
Location Saudi Arabia, Riyadh
commented
Status: Active » Needs review
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Local video not working on iOS » Fix not working local video on iOS
odai atieh’s picture

odai atieh
he/him
Primary language English
Location Saudi Arabia, Riyadh
commented

I updated the MR and moved the core patch to another issue on varbase core #3282848: Fix not working local video on iOS by adding a Drupal core patch fix for playsinline & muted options

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Fix not working local video on iOS » Fix not working local video on iOS with playsinline & muted options
Issue summary: View changes
Related issues: +#3046152: Add playsinline option to Video media file formatter, +#3282848: Fix not working local video on iOS by adding a Drupal core patch fix for playsinline & muted options
rajab natshah’s picture

rajab natshah
he/him
commented

Thank you, Odai for following up on the issue :)

Please, add a hook update to add content.field_media_video_file.settings.playsinline with true value in the core.entity_view_display.media.video.varbase_media_hero_slider config in active config. So that old sites will be able to fix that too.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented

  • Rajab Natshah committed 2729c04 on 10.0.x 
    Issue #3275939 by Odai Atieh: Fix not working local video on iOS with...
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Issue tags: +varbase-9.0.9, +varbase_heroslider_media-9.0.6
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released varbase_heroslider_media-9.0.6

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released Varbase 9.0.9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.