Problem/Motivation
Local video not working on iOS, I checked the issue and found that there are some policies for iOS that required a user gesture to play media in a or element.
Steps to reproduce
- Add local video content to Varbase Media Header Slider.
- Add the heroslider block to a page in the theme region or the homepage using the layout builder.
- Open the page on the safari browser on iPhone.
- You will notice that the video will not play in the background.
Proposed resolution
- I suggest adding 'playsinline' attribute for the video tag to better support inline playback on iOS.
- #3046152: Add playsinline option to Video media file formatter
- #3282848: Fix not working local video on iOS by adding a Drupal core patch fix for playsinline & muted options
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ Accessibility and Readability
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release Varbase 9.0.9, varbase_heroslider_media-9.0.6
Varbase update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Issue #3275939 by Odai Atieh: Fixed not working local video on iOS with
playsinline&mutedoptions
Issue fork varbase_heroslider_media-3275939
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
odai atiehComment #4
rajab natshahComment #5
odai atiehI updated the MR and moved the core patch to another issue on varbase core #3282848: Fix not working local video on iOS by adding a Drupal core patch fix for playsinline & muted options
Comment #6
rajab natshahComment #7
rajab natshahThank you, Odai for following up on the issue :)
Please, add a hook update to add
content.field_media_video_file.settings.playsinlinewith true value in thecore.entity_view_display.media.video.varbase_media_hero_sliderconfig in active config. So that old sites will be able to fix that too.Comment #8
rajab natshahComment #9
rajab natshahComment #12
rajab natshahComment #13
rajab natshahComment #14
rajab natshahComment #15
rajab natshahComment #16
rajab natshah✅ Released varbase_heroslider_media-9.0.6
Comment #17
rajab natshah✅ Released Varbase 9.0.9